[jbossts-issues] [JBoss JIRA] (JBTM-2081) Don't mandate a property file where possible

[Tom Jenkinson (JIRA)]

     [ https://issues.jboss.org/browse/JBTM-2081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tom Jenkinson updated JBTM-2081:
--------------------------------

        Status: Resolved  (was: Pull Request Sent)
    Resolution: Done


I merged a fix for this to not mandate a properties file. Looking at the code it does have defaults for a JTA implementation and these can be set by system properties or XML so I think mandating a config file is unfair.

As it stands we mandate certain properties be set, but if they are not then you will get a more meaningful error message, rather than just file not found:

{code}
java.lang.IllegalStateException: ARJUNA016111: The node identifier cannot be null
{code}
                
> Don't mandate a property file where possible
> --------------------------------------------
>
>                 Key: JBTM-2081
>                 URL: https://issues.jboss.org/browse/JBTM-2081
>             Project: JBoss Transaction Manager
>          Issue Type: Task
>      Security Level: Public(Everyone can see) 
>          Components: Transaction Core
>    Affects Versions: 5.0.0
>            Reporter: Mark Little
>            Assignee: Tom Jenkinson
>             Fix For: 5.0.2
>
>
> I noticed this originally when doing the Android port, but now again when doing vert.x: at some point over the years we appear to have moved to a model where the properties file must be present (e.g., in class path or CWD) or we exit. I'm not sure why we do this given that every property has a default value anyway.
> For example:
> java.lang.ExceptionInInitializerError: null
> 	at com.arjuna.common.util.propertyservice.PropertiesFactory.getPropertiesFromFile(PropertiesFactory.java:93)
> 	at com.arjuna.common.util.propertyservice.PropertiesFactory.initDefaultProperties(PropertiesFactory.java:236)
> 	at com.arjuna.common.util.propertyservice.PropertiesFactory.getDefaultProperties(PropertiesFactory.java:66)
> 	at com.arjuna.common.internal.util.propertyservice.BeanPopulator.getNamedInstance(BeanPopulator.java:77)
> 	at com.arjuna.common.internal.util.propertyservice.BeanPopulator.getDefaultInstance(BeanPopulator.java:49)
> 	at com.arjuna.ats.txoj.common.txojPropertyManager.getTxojEnvironmentBean(txojPropertyManager.java:48)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira