[jbossts-issues] [JBoss JIRA] (JBTM-2423) ORBRunner uses the orb after run() returns

[Michael Musgrove (JIRA)]

    [ https://issues.jboss.org/browse/JBTM-2423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13072019#comment-13072019 ] 

Michael Musgrove commented on JBTM-2423:
----------------------------------------

Since the run loop for JavaIdlRCServiceInit._orb has finished some code somewhere must have already called shutdown on it. The spec says that shutdown calls destroy on the root poa which in turn calls shutdown on its immediate descendants. So when the run loop finishes the code I have removed should effectively already have been called (ie both the shutdown on the orb and the destroy on the object adaptor).

The relevant bits of the spec I refer to are 4.2.5.4 shutdown
{quote}
Additionally in systems that have Portable Object Adapters (see Chapter 11)
shutdown behaves as if POA::destroy is called on the Root POA with its first
parameter set to TRUE and the second parameter set to the value of the
wait_for_completion parameter that shutdown is invoked with.
{quote}
and
{quote}
And POA::destroy will call destroy on all of its immediate descendants.
{quote}


> ORBRunner uses the orb after run() returns
> ------------------------------------------
>
>                 Key: JBTM-2423
>                 URL: https://issues.jboss.org/browse/JBTM-2423
>             Project: JBoss Transaction Manager
>          Issue Type: Bug
>            Reporter: Michael Musgrove
>            Assignee: Michael Musgrove
>
> ORBRunner.java starts an orb using orb().run() but then performs operations on the orb after the run() method returns. According to the CORBA spec this is invalid:
> {quote}
> Once an ORB has shutdown, only object reference management operations(duplicate,
> release and is_nil) may be invoked on the ORB or any object reference obtained
> from it.
> {quote}
> Note that when the orb.run() method returns the orb has shutdown because, for the run method, the spec states:
> {quote}
> This operation will block until the ORB has completed the shutdown process,
> {quote}
> This issue has arisen because of a change made to our fork of the jdk orb: in the jdk orb shutdown method we join with all the orb runners. This results in deadlock:
> # com.arjuna.orbportability.ORB.shutdown is a synchronized method and it calls shutdown on the jdk orb;
> # shutdown on the jdk orb notifies the ORBRunner thread which now tries to call back into a synchronized method of com.arjuna.orbportability.ORB but is blocked because the monitor is held
> # at this point the jdk orb shutdown would normally then return allowing the 
> the ORBRunner thread to make progress but a recent change now means that the jdk orb shutdown method performs a join() on the various ORBRunner threads



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)