[jbossts-issues] [JBoss JIRA] (JBTM-2423) ORBRunner uses the orb after run() returns
Tomasz Adamski (JIRA)
issues at jboss.org
Tue Sep 15 17:31:00 EDT 2015
[ https://issues.jboss.org/browse/JBTM-2423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13109011#comment-13109011 ]
Tomasz Adamski commented on JBTM-2423:
The issue returned in WFLY-5261. I was looking at the problem today. The problem is that shutdown hooks are not executed - among them is JavaIdlRCShutdown - lack of is execution causes the error in WFLY-5261.
In the changes about destruction of POA and shutdown of ORB were remove from ORBRunner class and:
// Ensure destroy is called on the root OA so that any pre/post destroy hooks get called
// Normally we expect whoever called shutdown to have done this however destroy is
// safe to call multiple times
code was added to ORBs shutdown method. The problem is that noone calls shutdown method too as it was executed only from ORBRunner class. On the other when we execute shutdown method from ORBRunner class we are violating specification which also leads to a problems that we were solving at the first place.
My suggestion would be to try perform destruction/shutdown in ORBRunner but only of the wrappers (without delegation to underlying ORB/POAs as we are sure they are already destroyed when ORBRunner runs).
I'm preparing quick test of that solution now - will test it and paste it in few minutes if it passes the test (and tomorrow if it doesn't :) ).
> ORBRunner uses the orb after run() returns
> Key: JBTM-2423
> URL: https://issues.jboss.org/browse/JBTM-2423
> Project: JBoss Transaction Manager
> Issue Type: Bug
> Reporter: Michael Musgrove
> Assignee: Tomasz Adamski
> Fix For: 5.2.0
> ORBRunner.java starts an orb using orb().run() but then performs operations on the orb after the run() method returns. According to the CORBA spec this is invalid:
> Once an ORB has shutdown, only object reference management operations(duplicate,
> release and is_nil) may be invoked on the ORB or any object reference obtained
> from it.
> Note that when the orb.run() method returns the orb has shutdown because, for the run method, the spec states:
> This operation will block until the ORB has completed the shutdown process,
> This issue has arisen because of a change made to our fork of the jdk orb: in the jdk orb shutdown method we join with all the orb runners. This results in deadlock:
> # com.arjuna.orbportability.ORB.shutdown is a synchronized method and it calls shutdown on the jdk orb;
> # shutdown on the jdk orb notifies the ORBRunner thread which now tries to call back into a synchronized method of com.arjuna.orbportability.ORB but is blocked because the monitor is held
> # at this point the jdk orb shutdown would normally then return allowing the
> the ORBRunner thread to make progress but a recent change now means that the jdk orb shutdown method performs a join() on the various ORBRunner threads
This message was sent by Atlassian JIRA
More information about the jbossts-issues