[jbossts-issues] [JBoss JIRA] (JBTM-2718) Make CompensatableActionImpl.WorkInfo class static

[Gytis Trikleris (JIRA)]

     [ https://issues.jboss.org/browse/JBTM-2718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Issue was automatically transitioned when Gytis Trikleris created pull request #1040 in GitHub
----------------------------------------------------------------------------------------------
    Status: Pull Request Sent  (was: Open)


> Make CompensatableActionImpl.WorkInfo class static
> --------------------------------------------------
>
>                 Key: JBTM-2718
>                 URL: https://issues.jboss.org/browse/JBTM-2718
>             Project: JBoss Transaction Manager
>          Issue Type: Task
>          Components: Compensations
>            Reporter: Gytis Trikleris
>            Assignee: Gytis Trikleris
>            Priority: Trivial
>             Fix For: 5.next
>
>
> If inner class does not require access to an enclosing instance there should be preffered to use inner static class.
> (21902 SIC: Inner class could be made static
> This class is an inner class, but does not use its embedded reference to the object which created it.)
> As reference I would mention Joshua Bloch: Effective Java, item 22.



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)