[jbossts-issues] [JBoss JIRA] (JBTM-2904) ConnectionManager no longer uses the underlying XADataSource's credentials when none are provided in its Properties

[Andy Wilkinson (JIRA)]

    [ https://issues.jboss.org/browse/JBTM-2904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13417476#comment-13417476 ] 

Andy Wilkinson commented on JBTM-2904:
--------------------------------------

Thank you, and apologies for not spotting the original issue.

> ConnectionManager no longer uses the underlying XADataSource's credentials when none are provided in its Properties
> -------------------------------------------------------------------------------------------------------------------
>
>                 Key: JBTM-2904
>                 URL: https://issues.jboss.org/browse/JBTM-2904
>             Project: JBoss Transaction Manager
>          Issue Type: Bug
>    Affects Versions: 5.5.7.Final
>            Reporter: Andy Wilkinson
>
> I believe that [this commit|https://github.com/jbosstm/narayana/commit/789a02b78c8ffe5a7a079604e9ba712287cdf7d1] has introduced a regression in how {{ConnectionManager}} handles credentials. Previously, if the {{Properties}} contained an {{XADataSource}} and no credentials, the data source's default credentials would be used, i.e. {{XADataSource.getXAConnection()}} would be called by {{ProvidedXADataSourceConnection}}. With the aforelinked change, {{ConnectionManager}} now coerces {{null}} credentials to empty strings. As a result {{XADataSource.getXAConnection(String, String)}} is called by {{ProvidedXADataSourceConnection}} with the empty credentials.



--
This message was sent by Atlassian JIRA
(v7.2.3#72005)