[jbossts-issues] [JBoss JIRA] (JBTM-3302) New PR job text should include our policy on running checkstyle

[Ondrej Chaloupka (Jira)]

     [ https://issues.redhat.com/browse/JBTM-3302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ondrej Chaloupka closed JBTM-3302.
----------------------------------


> New PR job text should include our policy on running checkstyle
> ---------------------------------------------------------------
>
>                 Key: JBTM-3302
>                 URL: https://issues.redhat.com/browse/JBTM-3302
>             Project: JBoss Transaction Manager
>          Issue Type: Enhancement
>          Components: Build System
>    Affects Versions: 5.10.4.Final
>            Reporter: Michael Musgrove
>            Assignee: Ondrej Chaloupka
>            Priority: Major
>             Fix For: 5.10.5.Final
>
>
> The PR text should include the following:
> {quote}
> Our style rules for submitting code are as follows:
>  
> * If you add a new file it MUST adhere to our checkstyle ruleset.
> * If you change a file (in a non trivial way) you are allowed (MAY) to reformat the code to conform to our checkstyle ruleset. If you choose not to reformat it then you SHOULD, where possible, try to follow the same style that's already in use for that file.
> Checkstyle is enabled via a boolean property "-Dcheckstyle" to the compilation.
> {quote}
> Note that we need our own property because you cannot override a plugin property that is already set in the plugin configuration section (ie -Dcheckstyle.skip=false does not work). The fix for this issue should include our new -Dcheckstyle property .



--
This message was sent by Atlassian Jira
(v7.13.8#713008)