[jbossws-issues] [JBoss JIRA] Updated: (JBWS-2559) Correct WeakReference handling in ConfigObservable to remove cleared WeakReferences

[Darran Lofthouse (JIRA)]

     [ https://jira.jboss.org/jira/browse/JBWS-2559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Darran Lofthouse updated JBWS-2559:
-----------------------------------

    Summary: Correct WeakReference handling in ConfigObservable to remove cleared WeakReferences  (was: Review EndpointMetaData and ConfigObservable)


> Correct WeakReference handling in ConfigObservable to remove cleared WeakReferences
> -----------------------------------------------------------------------------------
>
>                 Key: JBWS-2559
>                 URL: https://jira.jboss.org/jira/browse/JBWS-2559
>             Project: JBoss Web Services
>          Issue Type: Task
>      Security Level: Public(Everyone can see) 
>          Components: jbossws-native
>    Affects Versions: jbossws-native-3.0.5
>            Reporter: Darran Lofthouse
>             Fix For:  jbossws-native-3.1.1
>
>
> The implementation currently has: -
> private List<WeakReference<Observer>> observer = new ArrayList<WeakReference<Observer>>();
> However there is nothing to remove the WeakReference as it looses it's reference.
> Secondly notifyOberservers has: -
>            for (WeakReference<Observer> w : observer)
>             {
>                Observer tmp = w.get();
>                tmp.update(this, arg);
>             }
> As w is a WeakReference the value from get should be checked to ensure it is not null.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira