[jbossws-issues] [JBoss JIRA] (JBWS-3957) publishWsdlImports writes WSDL-XML files with wrong characterset under Windows

[Alessio Soldano (JIRA)]

    [ https://issues.jboss.org/browse/JBWS-3957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13134801#comment-13134801 ] 

Alessio Soldano commented on JBWS-3957:
---------------------------------------

Martin,
I've patched the AbstractWSDLFilePublisher as shown at https://github.com/jbossws/jbossws-common/commit/88dc3e05a00164adb0fb782c63de2d2649c4444f . I believe that should solve your problem, but it would be great if you could check / try the fix.
Besides that, few comments on the discussion above:
* JSR 109 actually requires us to write the published wsdl to the disk too (there few TCK tests covering this)
* you're right in saying that publish to disk could be performed in a more efficient way, as basically when there're xsd imports within imported wsdl, the imported wsdl is written and re-read again; feel free to send a patch/improvement for that and/or open up a jira
* wsdl4j looks to be in EOL mode (or dead, call it as you want), I've had bad luck too in the past proposing patches.

> publishWsdlImports writes WSDL-XML files with wrong characterset under Windows
> ------------------------------------------------------------------------------
>
>                 Key: JBWS-3957
>                 URL: https://issues.jboss.org/browse/JBWS-3957
>             Project: JBoss Web Services
>          Issue Type: Bug
>         Environment: WildFly 9, Windows 7 with default Java file.encoding Cp1252.
>            Reporter: Martin Both
>            Assignee: Alessio Soldano
>             Fix For: jbossws-cxf-5.2.0.Final
>
>
> I would like to deploy a WebService but I get an exception. The WSDL XSD file contains an german character 'ä'. See:
> Here is the part of the XSD:
>   <xs:simpleType name="Teilnehmerart">
>     <xs:restriction base="xs:string">
>       <xs:enumeration value="Privat"></xs:enumeration>
>       <xs:enumeration value="Geschäftlich"></xs:enumeration>
>     </xs:restriction>
>   </xs:simpleType>
> The JBoss class org.jboss.ws.common.utils.AbstractWSDLFilePublisher
> writes the imported WSDL file using a FileWriter at line 166 + 167.
>                 FileWriter fw = new FileWriter(targetFile);
>                wsdlWriter.writeWSDL(subdef, fw);
> In a next step this file is read again and results in an exception:
>  Invalid byte 2 of 3-byte UTF-8 sequence.
> This is because the file is written in Cp1252 enconding together with an XML prolog
> UTF-8 encoding. That is crazy and cannot work.
> A workaround would be to set the Java file.encoding to UTF-8 but that is not what I want.
> There are two solutions:
> I think it is better to create a binary OutputStream instead of creating a FileWriter.
> The wsdlWriter offers two methods! The method with OutputStream argument would always write XML files using a UTF-8 encoding.
> An other way to fix that would be a bug fix to WSDL4J 1.6.3.
> The WSDL4J method com.ibm.wsdl.xml.WSDLWriterImpl.writeWSDL(Definition wsdlDef, Writer sink) does map default Java file.encoding to "UTF-8". That is sometimes wrong.
> The class com.ibm.wsdl.util.xml.DOM2Writer should have an XmlEncodingMapping from "Cp1252" to "Windows-1252". That would fix the problem also. But I think it would be better to use always UTF-8 with the OutputStream method.
> Best regards
> Martin Both



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)