[jbpm-dev] Re: jbpm-3.2.5.SP

[Thomas Diesler]

Thanks. Do we have a test case that actually uses long strings?

Alejandro Guizar wrote:
> It was because of a request from Goldman Sachs:
> 
> https://jira.jboss.org/jira/browse/JBPM-701
> 
> Every mapping of a String field with length="4000" was replaced with
> type="text". The complete list of differences was compiled by Thomas in
> 
> https://jira.jboss.org/jira/browse/JBPM-1849
> 
> Back at the time we released 3.3.0 we discussed the consequences and our
> options. Either (a) rollback those changes or (b) verify they had no
> impact on existing database schemas.
> 
> Thomas verified the jTDS driver transparently handled the difference
> between varchar(4000) and text, as per the comment in
> 
> https://jira.jboss.org/jira/browse/JBPM-1849
> 
> I verified his findings on my local Sybase installation as well. If
> required, this verification can be repeated for each supported database.
> 
> There is an issue which I just spotted and will correct immediately.
> 
> https://jira.jboss.org/jira/browse/JBPM-2017
> 
> -Alejandro
> 
> El jue, 05-02-2009 a las 13:33 +0100, Thomas Diesler escribió:
>> Hi Julian,
>>
>> are you actually changing stuff at that level?
>>
>> We verify jBPM functionality and database backward compatibility with 
>> the hibernate mapping that is in place for a given version. We also 
>> generate SQL update scripts from those if needed.
>>
>> A change at that level is not cosmetic and effectively invalidates our QA.
>>
>> Are you saying that this issue needs to be reopened?
>>
>> StringInstance hbm configuration column length of 4000
>> https://jira.jboss.org/jira/browse/JBPM-1109
>>
>> Here is the changeset that removed length="4000"
>> http://fisheye.jboss.org/changelog/JbpmSvn?cs=2440
>>
>> Maybe Alejandro can fill in the details why length="4000" was removed.
>>
>> -thomas
>>
>> Julian Coleman wrote:
>>> Hi,
>>>
>>>> After you've taken the stuff back out again, could you please start  
>>>> another QA build for 3.2.5.SP? We can can only tag from a clean QA build.
>>> There is another blocking JIRA for SOA 4.3.0 CP01/jBPM 3.2.5 SP1 - SOA-1164.
>>> This is a new incarnation of the bug orginally discussed in SOA-271,
>>> JBESB-1435 and JBPM-1109.
>>>
>>> I am testing a build with the fix from JBPM-1109 applied to:
>>>
>>>   modules/core/src/main/resources/org/jbpm/context/exe/variableinstance/StringInstance.hbm.xml
>>>
>>> but I am unsure if:
>>>
>>>   modules/core/src/main/resources/org/jbpm/context/exe/variableinstance/HibernateStringInstance.hbm.xml
>>>   modules/core/src/main/resources/org/jbpm/context/log/variableinstance/StringUpdateLog.hbm.xml
>>>
>>> also need to be changed (or, indeed, if I have missed another location).  Any
>>> help/confirmation appreciated.  We can't tag SP1 until this is fixed.
>>>
>>> Thanks,
>>>
>>> J
>>>
>