[jbpm-dev] Re: jbpm-3.2.5.SP

[Thomas Diesler]

Mark Little wrote:
> Thomas, we are working on the understanding that what you are delivering 
> is based on the codebase that we have accepted into the SOA-P for the 
> past 12+ months. 

yes I saw what you have been accepting.

> If an issue is not covered by a jira then we should fix 
> that. But it does not remove the fact that the jBPM codebase you deliver 
> to us must be functionally equivalent to what we have been using, at 
> least in terms of bug fixes. this is orthogonal to qa coverage.

Well, I have no other way than a successful testrun that proves that 
stuff did not get broken.

> it's as simple as this: we do not release versions of the code that reintroduce 
> bugs fixed months/years previously. 

what specific bugs are you talking about? I need to see the jbpm test 
case for every one of them. If a bugfix is not covered by a test (and 
that is indeed a problem) it can break again unnoticed.

> OK, some issues may have been
> addressed before you took on your current role and therefore may have 
> slipped through cracks in the jBPM process at that time in terms of 
> jiras (not sure that is the case at all to be honest) but when you took 
> over it was clear that the codebase the soa-p needed had to be based on 
> the most recent *product* release codebase.

Ok, but then we should not have used jbpm-3.2.3 at all. However, at the 
time when we did it was commonly accepted that we move on from that version.

> 
> So please do an svn diff and let's get to the bottom of this now. 

The svn diff is massive (2MB) and incomprehensible. Even if I wanted, I 
cannot make an assertion based on that data on whether a number of 
unspecified issues is broken or not.

 > We can argue about what processes were broken and by whom after we have
> delivered this to the customer.
> 
> Mark.
> 
> 
> On 6 Feb 2009, at 11:22, Thomas Diesler wrote:
> 
>>
>>
>> trevor kirby wrote:
>>> Mark Little wrote:
>>>> Let's put it this way: we cannot release the current jbpm branch 
>>>> until we have confirmation that other issues have not been lost.
>>> Understood, SVN diff will help but given the refactoring, we'll have 
>>> to mainly rely on Thomas for confirmation.
>>
>> Well, no ;-)
>>
>> You can only rely on a successful QA run. Whether the QA coverage is 
>> comprehensive enough should be possible to find out.
>>
>>> Trev
>>>>
>>>> Mark.
>>>>
>>>>
>>>> On 6 Feb 2009, at 10:44, trevor kirby wrote:
>>>>
>>>>> Mark Little wrote:
>>>>>> Do we know if any other issues from the branch we were using are 
>>>>>> missing in action?
>>>>> We have no confirmation either way, so we will have to check, 
>>>>> Thomas does your hudson setupgive you any information about  SOA 
>>>>> related jiras that it tests against?
>>>>>
>>>>> Trev
>>>>>>
>>>>>> Mark.
>>>>>>
>>>>>>
>>>>>> On 6 Feb 2009, at 10:40, trevor kirby wrote:
>>>>>>
>>>>>>> Mark Little wrote:
>>>>>>>> What's the status?
>>>>>>> https://jira.jboss.org/jira/browse/JBPM-2017 - according to the 
>>>>>>> jira comment -  Corrected HibernateStringInstance.hbm.xml, made 
>>>>>>> the correction work for Sybase/jConnect, wrote test case.
>>>>>>> There was also an associated late night checkin, thanks Alejandro.
>>>>>>>
>>>>>>> https://jira.jboss.org/jira/browse/JBPM-2018 - should also be 
>>>>>>> fixed by this.
>>>>>>>
>>>>>>> https://jira.jboss.org/jira/browse/JBPM-2005 - examples - they 
>>>>>>> are still missing, but that is not a blocker. Thomas do we have 
>>>>>>> an ETA?
>>>>>>>
>>>>>>> https://jira.jboss.org/jira/browse/SOA-1157 - fixed by moving to 
>>>>>>> 3.2.5
>>>>>>>
>>>>>>> We are pulling the build and checking.
>>>>>>>
>>>>>>> Trev
>>>>>>>>
>>>>>>>> Mark.
>>>>>>>>
>>>>>>>>
>>>>>>>> On 5 Feb 2009, at 19:27, trevor kirby wrote:
>>>>>>>>
>>>>>>>>> Alejandro Guizar wrote:
>>>>>>>>>> I just joined the channel. I kinda prefer email, but I'll meet 
>>>>>>>>>> you guys
>>>>>>>>>> there.
>>>>>>>>>>
>>>>>>>>> We are in the UK, so you joined just after we left :-(
>>>>>>>>>
>>>>>>>>> Trev
>>>>>>>>>> -Alejandro
>>>>>>>>>>
>>>>>>>>>> El jue, 05-02-2009 a las 13:58 +0000, trevor kirby escribió:
>>>>>>>>>>
>>>>>>>>>>> Alejandro can you hop onto #jbosssoa  please so we can lose 
>>>>>>>>>>> some of the time lag in this discussion.
>>>>>>>>>>>
>>>>>>>>>>> Trev
>>>>>>>>>>>
>>>>>>>>>>> Julian Coleman wrote:
>>>>>>>>>>>
>>>>>>>>>>>> Hi,
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>> are you actually changing stuff at that level?
>>>>>>>>>>>>>
>>>>>>>>>>>> We don't make any changes here in the SOA platform build
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>> A change at that level is not cosmetic and effectively 
>>>>>>>>>>>>> invalidates our QA.
>>>>>>>>>>>>>
>>>>>>>>>>>> Indeed.  So this change will require a re-test.
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>> Are you saying that this issue needs to be reopened?
>>>>>>>>>>>>>
>>>>>>>>>>>> Yes.  The previous SOA version had a length of 4000, so this 
>>>>>>>>>>>> one needs it as
>>>>>>>>>>>> well.
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>> Here is the changeset that removed length="4000"
>>>>>>>>>>>>> http://fisheye.jboss.org/changelog/JbpmSvn?cs=2440
>>>>>>>>>>>>>
>>>>>>>>>>>> Thanks for the pointer.  I've tried reversing the removal of 
>>>>>>>>>>>> the length 4000
>>>>>>>>>>>> parts of that changeset, but the generated sql still has 
>>>>>>>>>>>> (e.g.) varchar(255)
>>>>>>>>>>>> and nothing with length 4000, so I must be missing something.
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>> Maybe Alejandro can fill in the details why length="4000" 
>>>>>>>>>>>>> was removed.
>>>>>>>>>>>>>
>>>>>>>>>>>> That might be useful.  Somehow, we need it back though ;-)
>>>>>>>>>>>>
>>>>>>>>>>>> Thanks,
>>>>>>>>>>>>
>>>>>>>>>>>> J
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>
>>>>>>>> ---
>>>>>>>> Mark Little
>>>>>>>> mlittle at redhat.com
>>>>>>>>
>>>>>>>> JBoss, a Division of Red Hat
>>>>>>>> Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 
>>>>>>>> Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom.
>>>>>>>> Registered in UK and Wales under Company Registration No. 
>>>>>>>> 3798903 Directors: Michael Cunningham (USA), Charlie Peters 
>>>>>>>> (USA), Matt Parsons (USA) and Brendan Lane (Ireland).
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>
>>>>>> ---
>>>>>> Mark Little
>>>>>> mlittle at redhat.com
>>>>>>
>>>>>> JBoss, a Division of Red Hat
>>>>>> Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 
>>>>>> Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom.
>>>>>> Registered in UK and Wales under Company Registration No. 3798903 
>>>>>> Directors: Michael Cunningham (USA), Charlie Peters (USA), Matt 
>>>>>> Parsons (USA) and Brendan Lane (Ireland).
>>>>>>
>>>>>>
>>>>>>
>>>>>
>>>>
>>>> ---
>>>> Mark Little
>>>> mlittle at redhat.com
>>>>
>>>> JBoss, a Division of Red Hat
>>>> Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod 
>>>> Street, Windsor, Berkshire, SI4 1TE, United Kingdom.
>>>> Registered in UK and Wales under Company Registration No. 3798903 
>>>> Directors: Michael Cunningham (USA), Charlie Peters (USA), Matt 
>>>> Parsons (USA) and Brendan Lane (Ireland).
>>>>
>>>>
>>>>
> 
> ---
> Mark Little
> mlittle at redhat.com
> 
> JBoss, a Division of Red Hat
> Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod 
> Street, Windsor, Berkshire, SI4 1TE, United Kingdom.
> Registered in UK and Wales under Company Registration No. 3798903 
> Directors: Michael Cunningham (USA), Charlie Peters (USA), Matt Parsons 
> (USA) and Brendan Lane (Ireland).
> 
> 
>