[jbpm-dev] [Design of JBoss jBPM] - Removed Timer/autosave in Revision 4006?

[camunda]

Bernd wrote : 
  | > Hi Alex!
  | > With Revision 4006 you removed the fix for
  | > https://jira.jboss.org/jira/browse/JBPM-1015 from the Timer class.
  | > basically this code:
  | > Was this by accident? Or what rational was behind this? Can I
  | > re-include it?
  | > Because now, Bug 1015 would occur again with jbpm 3.2.6
  | 

Alejandro wrote : 
  | While working on JBPM-2036, I noticed that the addAutoSaveToken call was
  | duplicated in all job classes, so I moved it to JobExecutorThread. Now
  | that you mention it, the code should be added to ExecuteJobCommand as
  | well.
  | 
  | Since no test failed, I assumed the net effect was the same. I guess it
  | broke something on your side. Care to tell me how to reproduce?
  | 

Hi Alex.

Couldn't we move this to the JobSession.loadJob() method? Now we have to spread this logic to JobExecutor, ExecuteJobCommand's and so on.

In my case, we have an own ExecuteJobCommand, since we do some additional stuff. So I had to change that as well to get the Tests green. Maybe other people do the same stuff?

And in JobSession it would be nice, since then it is "close" to the code handling persistence, or not?

Remarks?

@Ronald: Yeah, I see a slight chance, that it was missed to write a test for executing jobs via Command ;-)

Cheers
Bernd

P.S @Alex: I fly to Mexico next week. Maybe we could just meet for beer on around Tuesday 10.03. in Mexico City?

View the original post : http://www.jboss.org/index.html?module=bb&op=viewtopic&p=4213877#4213877

Reply to the post : http://www.jboss.org/index.html?module=bb&op=posting&mode=reply&p=4213877