[jbpm-issues] [JBoss JIRA] Created: (JBPM-1465) NullPointerException on transaction.rollback() in DbPersistenceService

[Martin Putz (JIRA)]

NullPointerException on transaction.rollback() in DbPersistenceService
----------------------------------------------------------------------

                 Key: JBPM-1465
                 URL: https://jira.jboss.org/jira/browse/JBPM-1465
             Project: JBoss jBPM
          Issue Type: Bug
      Security Level: Public (Everyone can see)
    Affects Versions: jPDL 3.2.3, SOA 4.2 CP02
            Reporter: Martin Putz
            Assignee: Alejandro Guizar


We are having NullPointerException from DbPersistenceService when Hibernate throws Exception on close() method. The line is transaction.rollback(); in rollback() method. My two cents is this code should be embraced with "if ( isTransactionEnabled && (transaction != null) )" statement, because we are using external JDBC Connection provider, and the transaction reference never be set.

All calls to the rollback() method in DbPersistenceService are already preceded by a check for

   if ( (isTransactionEnabled)
        && (transaction!=null)
      ) {

except this one after an exception has happened during the Hibernate session.flush call:

    Exception flushException = flushSession();
    if (flushException!=null) {
      rollback();                         // missing check if there is a transaction 
      closeSession();
      closeConnection();
      throw new JbpmPersistenceException("hibernate flush failed", flushException);
    }


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira