[jbpm-issues] [JBoss JIRA] Commented: (JBPM-1205) Cleanup stale core tests from the testsuite

[Thomas Diesler (JIRA)]

    [ https://jira.jboss.org/jira/browse/JBPM-1205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12426501#action_12426501 ] 

Thomas Diesler commented on JBPM-1205:
--------------------------------------

Tests need to be active, excluded (with a fixme) or not there. Please go through the above list and decide what it should be done for each. Renaming a test such that it is not recognized as a test should not be done.

> Cleanup stale core tests from the testsuite
> -------------------------------------------
>
>                 Key: JBPM-1205
>                 URL: https://jira.jboss.org/jira/browse/JBPM-1205
>             Project: JBoss jBPM
>          Issue Type: Task
>      Security Level: Public(Everyone can see) 
>          Components: jPDL 3
>    Affects Versions: jPDL 3.2.2
>            Reporter: Thomas Diesler
>             Fix For: JBossBPM-3.3.0.GA
>
>
> I believe this is the list of tests in 3.2.2.GA that are not run as part of the testsuite
>             <!-- Tests not part of AllTests  -->
>             <exclude>org/jbpm/context/exe/VariableQueryDbTest.java</exclude>            
>             <exclude>org/jbpm/db/ContextSessionDbTest.java</exclude>
>             <exclude>org/jbpm/DefaultConfigurationTest.java</exclude>
>             <exclude>org/jbpm/graph/def/ExceptionHandlerDbTest.java</exclude>
>             <exclude>org/jbpm/graph/def/TransitionDbTest.java</exclude>
>             <exclude>org/jbpm/graph/exe/StateDbTest.java</exclude>
>             <exclude>org/jbpm/graph/exe/SubProcessCancellationTest.java</exclude>
>             <exclude>org/jbpm/graph/exe/SuperStateActionExecutionDbTest.java</exclude>
>             <exclude>org/jbpm/graph/log/NodeLogTest.java</exclude>
>             <exclude>org/jbpm/instantiation/UserCodeInterceptorTest.java</exclude>
>             <exclude>org/jbpm/JbpmDefaultConfigTest.java</exclude>
>             <exclude>org/jbpm/job/executor/ConcurrencyTest.java</exclude>
>             <exclude>org/jbpm/job/executor/JobExecutorDbTest.java</exclude>
>             <exclude>org/jbpm/job/executor/JobLoadJoinTest.java</exclude>
>             <exclude>org/jbpm/job/executor/JobLoadSubProcessTest.java</exclude>
>             <exclude>org/jbpm/jpdl/convert/ConversionTestCase.java</exclude>
>             <exclude>org/jbpm/jpdl/xml/SchemaTest.java</exclude>
>             <exclude>org/jbpm/logging/exe/LoggingConfigDbTest.java</exclude>
>             <exclude>org/jbpm/logging/exe/LogLogTest.java</exclude>
>             <exclude>org/jbpm/mail/RealServerMailTestCase.java</exclude>
>             <exclude>org/jbpm/mock/JdbcProxyTest.java</exclude>
>             <exclude>org/jbpm/perf/PerfWithoutDbTest.java</exclude>
>             <exclude>org/jbpm/perf/StateUpdateTest.java</exclude>
>             <exclude>org/jbpm/perf/TasklistEagerLoadingTest.java</exclude>
>             <exclude>org/jbpm/perf/TaskWithVariablesTest.java</exclude>
>             <exclude>org/jbpm/persistence/db/PersistenceConfigurationTest.java</exclude>
>             <exclude>org/jbpm/scheduler/exe/UnsafeSessionUsageTest.java</exclude>
>             <exclude>org/jbpm/seam/SeamPageFlowTest.java</exclude>
> To cleanup, do one of the following
> #1 enable the test
> #2 remove the test from SVN
> #3 disable the test with a FIXME
> #4 put the test in the exclude file
> void testFoo() {
>   
>   if(true)
>   {
>       System.out.println("FIXME: [JBPM-1234] some issue that needs fixing");
>       return;
>   }
> }
> The union of tests in the exclude file and FIXME disabled tests are the errata for a given release.
> Do not silently disable/exclude a test. There must be a jira associated.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira