[jbpm-issues] [JBoss JIRA] Created: (JBPM-2752) SpringTransactionInterceptor unnecessarily casts PlatformTransactionManager to AbstractPlatformTransactionManager

[Adam Galloway (JIRA)]

SpringTransactionInterceptor unnecessarily casts PlatformTransactionManager to AbstractPlatformTransactionManager
-----------------------------------------------------------------------------------------------------------------

                 Key: JBPM-2752
                 URL: https://jira.jboss.org/jira/browse/JBPM-2752
             Project: jBPM
          Issue Type: Bug
      Security Level: Public (Everyone can see)
          Components: Runtime Engine
    Affects Versions: jBPM 4.x
         Environment: Spring DM Server
            Reporter: Adam Galloway


In the execute() method of SpringTransactionInterceptor the results of resolveTransactionManager() are cast to an AbstractPlatformTransactionManager and then passed to a TransactionTemplate.  

The TransactionTemplate only requires a PlatformTransactionManager and none of the AbstractPlatformTransactionManager methods are referenced anywhere else in the SpringTransactionInterceptor.  So it appears that this casting to an AbstractPlatformTransactionManager is unnecessary.

This is causing a problem when using proxied PlatformTransactionManager objects in Spring DM.  The proxied object is exposed using the PlatformTransactionManger interface but cannot be cast to an AbstractPlatformTransactionManager, as that is one of the joys of working with proxied OSGI objects.


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira