<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Amazing job, Sande!<br>
<br>
Thanks. It was more than I expected. <br>
<br>
I saw your questions and I'll review it as I get close to modify
QSTools. <br>
<br>
I'm working on Drools examples and I'd like to have QSTools to make
the job for me. So it is probable that I'll update it (depending on
the necessary effort) to have it prepared to handle quickstarts from
different sources and use it on Drools examples.<br>
<br>
Thanks once more<br>
<br>
<br>
<div class="moz-cite-prefix">Em 17/07/13 14:52, Sande Gilda
escreveu:<br>
</div>
<blockquote cite="mid:51E6D9CB.1080201@redhat.com" type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
My first cut at modifying the QSTools to verify by product is
under "
<meta http-equiv="content-type" content="text/html;
charset=ISO-8859-1">
Modify the QSTools to use Product Specific Requirements" here: <a
moz-do-not-send="true"
href="https://docspace.corp.redhat.com/docs/DOC-132902#modify-the-qstools-to-use-product-specific-requirements">https://docspace.corp.redhat.com/docs/DOC-132902</a><br>
<br>
Feedback and suggestions are welcome!<br>
<br>
<div class="moz-cite-prefix">On 07/15/2013 08:51 PM, Rafael
Benevides wrote:<br>
</div>
<blockquote cite="mid:51E4991A.6010307@redhat.com" type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
<br>
<div class="moz-cite-prefix">Em 15/07/13 20:54, Sande Gilda
escreveu:<br>
</div>
<blockquote cite="mid:51E48BB9.1000307@redhat.com" type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
<br>
<div class="moz-cite-prefix">On 07/15/2013 06:18 PM, Rafael
Benevides wrote:<br>
</div>
<blockquote cite="mid:51E47525.1040606@redhat.com" type="cite">
<meta http-equiv="content-type" content="text/html;
charset=ISO-8859-1">
Hi all, Sande and Pete,<br>
<br>
One significant change in JDF Quickstarts repo is the use of
git submodules to bring remote quickstarts to JDF. But...
Sometimes remote quickstarts doesn't ( and don't want/need
to ) follow JDF Contributing guide ( <a
moz-do-not-send="true" class="moz-txt-link-freetext"
href="https://github.com/jboss-jdf/jboss-as-quickstart/blob/master/CONTRIBUTING.md">https://github.com/jboss-jdf/jboss-as-quickstart/blob/master/CONTRIBUTING.md</a>
).<br>
<br>
There are some requirements from QSTools ( <a
moz-do-not-send="true" class="moz-txt-link-freetext"
href="https://docspace.corp.redhat.com/docs/DOC-132902">https://docspace.corp.redhat.com/docs/DOC-132902</a>
) that I believe that we should update to split in two
categories ( desired and mandatory ).<br>
<br>
The definitions bellow are what I see differences across
JBoss projects:<br>
- package and groupId name (of course) - We already defined
that using org.jboss.quickstarts.(eap|wfk|...) is optional
from other Quickstarts (not JDF) but should be consistent
within the product<br>
</blockquote>
Agreed. Could we define properties or some other type of file
that could define the valid packages, groups, etc for each
product?<br>
</blockquote>
<br>
Yes. That's Pete's suggestion. We could keep this definition
file on QStools github repo. I thought in a yaml format to keep
it.<br>
<br>
Sande, Can you edit the QSTools requirement docspace to define
what should be a "per product" Checker ? Nobody other than you
is the best to provide this definition. I understand that what
will not be a "per product" Checker, it should be a mandatory
instruction.<br>
<br>
With this in hand I can start a QSTools refactoring. I was
wondering that a "per product" violation is a "warning" level
violation and I'll sign it on QSTools report with a yellow
color. In a mandatory violation I'll sign it with a red color. <br>
<br>
I'm trying to make QSTools a tooling to help us and it should be
update as we need. But recently, the reported violations seems
more a barrier than a gate.<br>
<br>
Pete,<br>
<br>
Any objections ?<br>
<blockquote cite="mid:51E48BB9.1000307@redhat.com" type="cite">
<blockquote cite="mid:51E47525.1040606@redhat.com" type="cite">
- License Headers<br>
</blockquote>
Yes. We saw this with the Spring-based quickstarts that
originate elsewhere. I'd still like to see this reported in
case they are EAP quickstarts.<br>
<blockquote cite="mid:51E47525.1040606@redhat.com" type="cite">
-
<meta charset="utf-8">
Spacing and Indentation formats<br>
<br>
</blockquote>
I don't see this as being something someone would object too.
But maybe I'm wrong? Again, I'd still like to see this
reported in case they are EAP quickstarts.<br>
<br>
</blockquote>
One example: The Infinispan project is the one who uses a
different format. They use 3-space for indentation.<br>
<br>
<blockquote cite="mid:51E48BB9.1000307@redhat.com" type="cite">
<blockquote cite="mid:51E47525.1040606@redhat.com" type="cite">
What do you think? Is it it desired to be more or less
restrictive for other quickstarts and also turn it in an
automated pattern?<br>
<br>
I'm bringing this discussion mainly because it is a
recurrent discussion for remote projects like <br>
- Infinispan: <a moz-do-not-send="true"
class="moz-txt-link-freetext"
href="https://github.com/infinispan/jdg-quickstart/pull/20#issuecomment-20968520">https://github.com/infinispan/jdg-quickstart/pull/20#issuecomment-20968520</a><br>
- GateIn: <a moz-do-not-send="true"
class="moz-txt-link-freetext"
href="http://transcripts.jboss.org/channel/irc.freenode.org/%23jboss-jdf/2013/%23jboss-jdf.2013-06-21.log.html#t2013-06-21T13:39:31">http://transcripts.jboss.org/channel/irc.freenode.org/%23jboss-jdf/2013/%23jboss-jdf.2013-06-21.log.html#t2013-06-21T13:39:31</a><br>
- And probable new others like BRMS, Fuse and Switchyard
Quickstarts.<br>
</blockquote>
</blockquote>
- Adding Spring Quickstarts to the list :)<br>
<blockquote cite="mid:51E48BB9.1000307@redhat.com" type="cite">
<blockquote cite="mid:51E47525.1040606@redhat.com" type="cite">
<br>
<meta charset="utf-8">
<meta charset="utf-8">
<pre class="moz-signature" cols="72">--
Rafael Benevides | Senior Software Engineer
Red Hat Brazil
+55-61-9269-6576
Better technology. Faster innovation. Powered by community collaboration.
See how it works at redhat.com </pre>
</blockquote>
<br>
</blockquote>
<br>
</blockquote>
<br>
</blockquote>
<br>
</body>
</html>