<html>
<head>
<meta http-equiv="content-type" content="text/html; charset=ISO-8859-1">
</head>
<body bgcolor="#FFFFFF" text="#000000">
This is the first PR of the BRMS quickstarts to align it to JDF
Guidelines.<br>
<br>
I would like a detailed review on this quickstart (specially on the
way it is organized since it is a little bit different from all
other quickstarts).<br>
<br>
<meta charset="utf-8">
<meta charset="utf-8">
This are the changes made:<br>
<br>
- Removed eclipse files (.project, .classpath, .settings)<br>
- Added License Headers<br>
- Added License to pom.xml<br>
- Changed groupId, version and name to match JDF rules<br>
- Changed pom property from brms-version to version.brms<br>
- Added Readme.md file ( I tried to keep it simple )<br>
- Format source code as <a class="moz-txt-link-freetext" href="https://github.com/jboss/ide-config">https://github.com/jboss/ide-config</a>
definition<br>
<br>
The Pull Request with the changes is
<a class="moz-txt-link-freetext" href="https://github.com/eschabell/brms-customer-evaluation-demo/pull/3">https://github.com/eschabell/brms-customer-evaluation-demo/pull/3</a><br>
<br>
I'd like your revision and opinion and since we get an approval (and
merge) those changes, I can move forward to update all other
quickstarts using the same criteria. <br>
<br>
For the last, we will add them as git submodule (for each quickstart
under a brms-quickstarts folder) on
<a class="moz-txt-link-freetext" href="https://github.com/jboss-jdf/jboss-as-quickstart">https://github.com/jboss-jdf/jboss-as-quickstart</a> <br>
<br>
Eric,<br>
<br>
You did a nice job on those quickstarts!<br>
<pre class="moz-signature" cols="72">--
Rafael Benevides | Senior Software Engineer
Red Hat Brazil
+55-61-9269-6576
Better technology. Faster innovation. Powered by community collaboration.
See how it works at redhat.com </pre>
</body>
</html>