[jsr-314-open-mirror] [jsr-314-open] [777-FaceletCache] RESOLVED (was: [2.1 Spec Review] FaceletCache issues)

Ed Burns edward.burns at oracle.com
Mon Oct 25 14:17:11 EDT 2010


>>>>> On Thu, 21 Oct 2010 16:26:48 -0400, Andy Schwartz <andy.schwartz at oracle.com> said:

AS> Some additional issues that turned up while reviewing the API doc:
AS> 1. FaceletCache and FaceletCacheFactory are missing documentation.

AS> The original (Mojarra implementation-specific) version of this 
AS> functionality does include documentation, but that doesn't seem to have 
AS> carried over into the  public API.

DONE.

AS> 2. The doc in FaceletCache.MemberFactory is incorrect

AS> The class doc says: "Factory interface for creating FaceletHandler 
AS> instances."  However, we're actually creating Facelet instances, not 
AS> FaceletHandler instances.

DONE.

AS> 3. Wider access than necessary for some methods in FaceletCache

AS> The original (Mojarra-specific) version of this functionality exposes 
AS> the following methods:

AS>     public final void init(InstanceFactory<V> faceletFactory, 
AS> InstanceFactory<V> metafaceletFactory)
AS>     protected final InstanceFactory<V> getFaceletInstanceFactory()
AS>     protected final InstanceFactory<V> getMetadataFaceletInstanceFactory()

AS> The equivalent methods in the new public API are:

AS>     public void setMemberFactories(MemberFactory<V> faceletFactory,
AS>             MemberFactory<V> viewMetadataFaceletFactory)
AS>     public MemberFactory<V> getMemberFactory()
AS>     public MemberFactory<V> getMetadataMemberFactory()

DONE.

-- 
| edward.burns at oracle.com | office: +1 407 458 0017
| homepage:               | http://ridingthecrest.com/
| 12 work days until German Oracle User's Group Conference



More information about the jsr-314-open-mirror mailing list