[jsr-314-open-mirror] [jsr-314-open] [153-UIDataTransient] RESOLVED Re: [2.1 Spec Review] Transient State [Was: Fix UIData state saving model]

Ed Burns edward.burns at oracle.com
Fri Oct 29 16:29:44 EDT 2010


>>>>> On Thu, 21 Oct 2010 12:27:46 -0400, Andy Schwartz <andy.schwartz at oracle.com> said:

MM> I agree with the points:

MM> - get/putTransient should be on UIComponent, or TransientStateHelper
MM> needs to be exposed
MM> - no Serializable keys are necessary

AS> Great.

MM> But - I am not sure about removing the TransientStateHelper
MM> contract... It doesn't need to extend from StateHelper,

AS> Yep.

MM> that is true -
MM> but won't the code look funny if state-saved property handling looks
MM> different from transient property handling?

AS> The first patch does the following:

AS> - Serializable -> Object for keys
AS> - TransientStateHelper no longer extends StateHelper
AS> - UIComponent.getTransientStateHelper() methods are public
AS> - The 1-arg versions of getTransientStateHelper() and getTransient() are 
AS> now final (convenience methods)
AS> - While I was in the code, I optimized the save/restoreTransientState() 
AS> methods to avoid unnecessary instantiation of the ComponentStateHelper

I have committed this.  Thanks Andy for supplying it.

Ed

-- 
| edward.burns at oracle.com | office: +1 407 458 0017
| homepage:               | http://ridingthecrest.com/
|  8 work days until German Oracle User's Group Conference



More information about the jsr-314-open-mirror mailing list