<div class="gmail_quote"><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">Hey Kito -<br>
<br>
Thanks again for looking at this. So regarding the BehaviorHolder/ClientBehaviorHolder, the reason why I moved this over to ClientBehaviorHolder is because the two methods that actually deal with Behaviors really do want ClientBehaviors, not just any Behaviors. These methods are:<br>
<br>
public void addClientBehavior(String eventName, ClientBehavior behavior);<br>
<br>
Note that this method is "event" specific - ie. it is implied that you are attaching a behavior to a specific client-side event for the purpose of providing a script for that event, so this really expects ClientBehavior, not just any Behavior.</blockquote>
<div><br>Ah, I see. <br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><br>
<br>
And:<br>
<br>
public Map<String, List<ClientBehavior>> getClientBehaviors();<br>
<br>
This method returns the mappings between event names and ClientBehaviors. So again, this is very event/client-specific. As such, I prefer not go with ClientBehaviorHolder rather than parameterize this type.</blockquote>
<div><br>Ok. Fair enough. Sounds good, then. <br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><br>
<br>
BTW - the current status on the refactoring, after discussing this with Ed and Roger - I am planning to merge at 6PM EST. So if anyone objects to this last minute refactoring, please speak up.<br>
<br>
Martin -<br>
<br>
I would still like to hear confirmation from you that this addresses your concerns. I'll definitely sleep better knowing this. :-)<br>
<br>
Andy<br>
<br>
Kito Mann wrote On 3/12/2009 3:42 PM ET:<div><div></div><div class="h5"><br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Andy,<br>
<br>
In general, +1. I wonder, however, if ClienyBehaviorHolder shouldn't be BehaviorHolder<? extends Behavior>. <br>
Sent from my iPhone<br>
<br>
<a href="http://www.jsfcentral.com" target="_blank">http://www.jsfcentral.com</a><br>
<a href="http://www.Virtua.com" target="_blank">http://www.Virtua.com</a><br>
<br>
<br>
</blockquote>
</div></div></blockquote></div><br>