<HTML dir=ltr><HEAD><TITLE>Re: More spec issues</TITLE>
<META http-equiv=Content-Type content="text/html; charset=unicode">
<META content="MSHTML 6.00.6000.16674" name=GENERATOR></HEAD>
<BODY>
<DIV id=idOWAReplyText16451 dir=ltr>
<DIV dir=ltr><FONT face=Arial color=#000000 size=2>Hi,</FONT></DIV>
<DIV dir=ltr><FONT face=Arial size=2></FONT> </DIV>
<DIV dir=ltr><FONT face=Arial size=2>I'm working on MyFaces. Alright for the other comments.</FONT></DIV>
<DIV dir=ltr><FONT face=Arial size=2></FONT> </DIV>
<DIV dir=ltr><FONT face=Arial size=2></FONT> </DIV>
<DIV dir=ltr><FONT face=Arial size=2>Regards,</FONT></DIV>
<DIV dir=ltr><FONT face=Arial size=2></FONT> </DIV>
<DIV dir=ltr><FONT face=Arial size=2>~ Simon</FONT></DIV>
<DIV dir=ltr><FONT face="Courier New"></FONT> </DIV></DIV>
<DIV dir=ltr><BR>
<HR tabIndex=-1>
<FONT face=Tahoma size=2><B>From:</B> JSR 314 Open Mailing list on behalf of Ed Burns<BR><B>Sent:</B> Fri 3/27/2009 9:55 PM<BR><B>To:</B> JSR-314-OPEN@JCP.ORG<BR><B>Subject:</B> Re: More spec issues<BR></FONT><BR></DIV>
<DIV>
<P><FONT size=2>>>>>> On Fri, 27 Mar 2009 11:15:08 -0400, Simon Lessard <Simon_Lessard@DMR.CA> said:<BR><BR>SL> Hi all,<BR>SL> I have a couple more issues I found while implementing the latest<BR>SL> spec:<BR><BR>Thanks. Can you share with the EG if you're doing a complete new Impl?<BR>This would be big news for me because AFAIK, Sun and Apache are the only<BR>ones doing new JSF2 impls.<BR><BR>SL> * ViewHandler.FACELETS_VIEW_MAPPINGS_PARAM_NAME: The doc says that<BR><BR>I'll let others chime in on that one. The behavior as specified seems<BR>useful to me.<BR><BR>SL> * ViewHandler.getPageDeclarationLanguage(): JavaDoc gives two<BR>SL> default implementations, one invoking the factory from FactoryFinder<BR>SL> (useful) and the throws UnsupportedOperationException<BR>SL> one. Personally, I'd keep only the real method here as the<BR>SL> processing doesn't involve any private/non standard API;<BR><BR>I see your point, but we did it this way to allow JSF 1.2 ViewHandlers<BR>to easily be detected, so we'll leave this the same as well.<BR><BR>SL> * AjaxBehavior.getHints(): JavaDoc says it should return an emprt<BR>SL> Set (like ClientBehaviorBase), making the method declaration in<BR>SL> AjaxBehavior useless. However Mojarra returns a Set containing<BR>SL> SUBMITTING, so I assume the code is right and the JavaDoc wrong<BR>SL> here;<BR><BR>Roger integrted this one.<BR><BR>SL> * UIComponentBase.initialStateMarked(): This method is not defined<BR>SL> in the JavaDoc while the two others from PartialStateHolder are.<BR><BR>I think this one's ok as is.<BR><BR>SL> * ExternalContext.getRequestCookieMap(): Can the return value be<BR>SL> changed from Map<String,Object> to Map<String, Cookie> please?<BR><BR>We can't do that because Cookie is declared in the Servlet spec, and<BR>Portlet people wouldn't be happy if we added that to our API.<BR><BR>SL> * PageDeclarationLanguageFactory.getPageDeclarationLanguage(String<BR>SL> viewId): The JavaDoc says that ClassNotFoundException should be<BR>SL> thrown when no valid PLD can be found. However,<BR>SL> ClassNotFoundException is a checked exception and the method does<BR>SL> not that this exception in its throws clause. The doc should either<BR>SL> says to wrap it in a FacesException or add ClassNotFoundException to<BR>SL> the throws clause;<BR><BR>I've removed the @throws ClassNotFoundException<BR><BR>SL> * ExceptionHandler.handle(): The spec specifies that this method<BR>SL> should only throw a FacesException if an internal error occurs while<BR>SL> handling the exception. However, it also says to throw either<BR>SL> ServletException or PortletException depending on the environment<BR>SL> and those are checked exception not declared in the throws<BR>SL> clause. Mojarra wrap them in a FacesException, so the spec mighth<BR>SL> ave to be ajusted to reflect that.<BR><BR>SL> That's all for now,<BR><BR><BR><BR>SL> ~ Simon<BR><BR><BR><BR><BR>SL> ________________________________<BR><BR>SL> From: JSR 314 Open Mailing list on behalf of Ed Burns<BR>SL> Sent: Fri 3/27/2009 10:30 AM<BR>SL> To: JSR-314-OPEN@JCP.ORG<BR>SL> Subject: Rename: PDL->VDL<BR><BR><BR><BR>SL> We have "View" everywhere else, so we should rename<BR>SL> PageDeclarationLanguage to ViewDeclarationLanguage.<BR><BR>SL> I'm taking care of this now.<BR><BR>SL> Ed<BR>SL> --<BR>SL> | ed.burns@sun.com | office: 408 884 9519 OR x31640<BR>SL> | homepage: | <A href="http://ridingthecrest.com/">http://ridingthecrest.com/</A><BR><BR><BR>SL> <HTML dir=ltr><HEAD><TITLE>Rename: PDL->VDL</TITLE><BR>SL> <META http-equiv=Content-Type content="text/html; charset=unicode"><BR>SL> <META content="MSHTML 6.00.6000.16674" name=GENERATOR></HEAD><BR>SL> <BODY><BR>SL> <P><FONT face=Arial size=2>Hi all,</FONT></P><BR>SL> <P><FONT face=Arial size=2>I have a couple more issues I found while implementing the latest spec:</FONT></P><BR>SL> <UL><BR>SL> <LI><FONT face=Arial size=2>ViewHandler.FACELETS_VIEW_MAPPINGS_PARAM_NAME: The doc says that the implementation should also read original Facelets' param for the purpose of defining mappings. I don't think that's a good idea. Facelets was not a standard up to that point and users shouldn't really expect no migration effort at all. I know that enforcing that param would allow xisting applications using facelet.jar to be deployed in 2.0 environment, but to my knòwledge, no other spec read some non standard context params (I may be wrong though). If we do enforce the original parameters, then we'll be stuck with it forever so at least let use only that one and not define a new one;</FONT></LI><BR>SL> <LI><FONT face=Arial size=2>ViewHandler.getPageDeclarationLanguage(): JavaDoc gives two default implementations, one invoking the factory from FactoryFinder (useful) and the throws UnsupportedOperationException one. Personally, I'd keep only the real method here as the processing doesn't involve any private/non standard API;</FONT></LI><BR>SL> <LI><FONT face=Arial size=2>AjaxBehavior.getHints(): JavaDoc says it should return an emprt Set (like ClientBehaviorBase), making the method declaration in AjaxBehavior useless. However Mojarra returns a Set containing SUBMITTING, so I assume the code is right and the JavaDoc wrong here;</FONT></LI><BR>SL> <LI><FONT face=Arial size=2>UIComponentBase.initialStateMarked(): This method is not defined in the JavaDoc while the two others from PartialStateHolder are.</FONT></LI><BR>SL> <LI><FONT face=Arial size=2>ExternalContext.getRequestCookieMap(): Can the return value be changed from Map&lt;String,Object&gt; to Map&lt;String, Cookie&gt; please?</FONT></LI><BR>SL> <LI><FONT face=Arial size=2>PageDeclarationLanguageFactory.getPageDeclarationLanguage(String viewId): The JavaDoc says that ClassNotFoundException should be thrown when no valid PLD can be found. However, ClassNotFoundException is a checked exception and the method does not that this exception in its throws clause. The doc should either says to wrap it in a FacesException or add ClassNotFoundException to the throws clause;</FONT></LI><BR>SL> <LI><FONT face=Arial size=2>ExceptionHandler.handle(): The spec specifies that this method should only throw a FacesException if an internal error occurs while handling the exception. However, it also says to throw either ServletException or PortletException depending on the environment and those are checked exception not declared in the throws clause. Mojarra wrap them in a FacesException, so the spec mighth ave to be ajusted to reflect that.</FONT></LI></UL><BR>SL> <P><FONT face=Arial size=2>That's all for now,</FONT></P><BR>SL> <P><FONT face=Arial size=2></FONT>&nbsp;</P><BR>SL> <P><FONT face=Arial size=2>~ Simon</FONT></P><BR>SL> <P><BR></P><BR>SL> <DIV dir=ltr><BR>SL> <HR tabIndex=-1><BR>SL> </DIV><BR>SL> <DIV dir=ltr><FONT face=Tahoma size=2><B>From:</B> JSR 314 Open Mailing list on behalf of Ed Burns<BR><B>Sent:</B> Fri 3/27/2009 10:30 AM<BR><B>To:</B> JSR-314-OPEN@JCP.ORG<BR><B>Subject:</B> Rename: PDL-&gt;VDL<BR></FONT><BR></DIV><BR>SL> <DIV><BR>SL> <P><FONT size=2>We have "View" everywhere else, so we should rename<BR>PageDeclarationLanguage to ViewDeclarationLanguage.<BR><BR>I'm taking care of this now.<BR><BR>Ed<BR>--<BR>| ed.burns@sun.com&nbsp; | office: 408 884 9519 OR x31640<BR>| homepage:&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; | <A href="<A href="http://ridingthecrest.com/">http://ridingthecrest.com/</A>"><A href="http://ridingthecrest.com/">http://ridingthecrest.com/</A></A><BR></FONT></P></DIV></BODY></HTML><BR><BR>--<BR>| ed.burns@sun.com | office: 408 884 9519 OR x31640<BR>| homepage: | <A href="http://ridingthecrest.com/">http://ridingthecrest.com/</A><BR></FONT></P></DIV></BODY></HTML>