<div class="gmail_quote">On Thu, Apr 2, 2009 at 4:02 PM, Alexandr Smirnov <span dir="ltr"><<a href="mailto:asmirnov@exadel.com">asmirnov@exadel.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
After a code review, I concern about properly implementation. The old<br>
facelets patch supports only pre-defined set of most popular HTML dtd's<br>
Obliviously, direct requests to the online definitions should be<br>
disabled, because it could take significant impact to the application<br>
performance and crush application if server has no direct internet access.</blockquote><div><br>It should definitely not be reaching out to the internet. <br><br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
The possible options are:<br>
1 VDL compiler resolves pre-defined entities only but block any other<br>
from loading.<br>
2 Create cached entity resolver and load any referenced entities from<br>
internet only once.<br>
3 Use configurable entity resolver. Implementation could define init<br>
parameter to enable resolver and define place of the configuration file<br>
( For example, as OASIS XML catalog format ).<br>
4. Combination of the options 1 and 3. Provide most used entities 'in<br>
the box' with optional configurable catalog.</blockquote><div><br>#4 sounds reasonable to me. If the user configures a catalog, then it would be acceptable for it to use a URI request. But no internet connection should be required for the built in entities. I think we are looking for the common ones. Those would be (available at W3C or in any XML package for Linux):<br>
<br><!ENTITY % HTMLlat1 PUBLIC<br> "-//W3C//ENTITIES Latin 1 for XHTML//EN"<br> "xhtml-lat1.ent"><br>%HTMLlat1;<br><br><!ENTITY % HTMLsymbol PUBLIC<br> "-//W3C//ENTITIES Symbols for XHTML//EN"<br>
"xhtml-symbol.ent"><br>%HTMLsymbol;<br><br><!ENTITY % HTMLspecial PUBLIC<br> "-//W3C//ENTITIES Special for XHTML//EN"<br> "xhtml-special.ent"><br>%HTMLspecial;<br><br>-Dan</div>
</div><br>-- <br>Dan Allen<br>Senior Software Engineer, Red Hat | Author of Seam in Action<br><br><a href="http://mojavelinux.com">http://mojavelinux.com</a><br><a href="http://mojavelinux.com/seaminaction">http://mojavelinux.com/seaminaction</a><br>
<br>NOTE: While I make a strong effort to keep up with my email on a daily<br>basis, personal or other work matters can sometimes keep me away<br>from my email. If you contact me, but don't hear back for more than a week,<br>
it is very likely that I am excessively backlogged or the message was<br>caught in the spam filters. Please don't hesitate to resend a message if<br>you feel that it did not reach my attention.<br>