Hi<br><br><div class="gmail_quote">2010/6/10 Andy Schwartz <span dir="ltr"><<a href="mailto:andy.schwartz@oracle.com">andy.schwartz@oracle.com</a>></span><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
Gang -<br>
<br>
I recently logged the following spec issue:<br>
<br>
<a href="https://javaserverfaces-spec-public.dev.java.net/issues/show_bug.cgi?id=806" target="_blank">https://javaserverfaces-spec-public.dev.java.net/issues/show_bug.cgi?id=806</a><br>
<br>
Short summary of the problem for those who don't want to read through the gory details:<br>
<br>
The specification is currently a bit too specific about when PostRestoreStateEvents should be delivered. The only requirement should be that these events are delivered after the view has been restored, but before we move out of the restore view phase. For example, a reasonable implementation would be to deliver these events in the Lifecycle implementation, after the state manager has returned the restored view. However, the spec does not currently allow this - eg. the spec requires that UIViewRoot.processRestoreState() delivers these events.<br>
<br>
Of course, UIViewRoot.processRestoreState isn't always called (only used for full state saving), which means that implementations end up having to duplicate this logic elsewhere, such as in whatever state manager is used for partial state saving. This has further fallout for custom state managers - ie. custom state managers that do not call processRestoreState() must duplicate the event delivery logic yet again.<br>
<br>
This is much more complicated than necessary. My recommendation is that we simplify the requirements such that implementations are free to deal with PostRestoreStateEvent delivery in a saner way. For example, implementations should be able to deliver these events once at the end of the restore view phase (and not be required to implement this logic in UIViewRoot.processRestoreState()).<br>
<br>
I suspect that this small spec change will lead to simpler code in Mojarra (definitely) and MyFaces (probably, though I haven't looked at the code).<br>
<br>
Does anyone have concerns about this proposal?<br>
<br>
Martin, Leonardo -<br>
<br>
Could you guys comment on whether this change would be acceptable to MyFaces?<br><font color="#888888">
<br></font></blockquote><div><br>I think this one has enough importance to be included on myfaces core 2.0.1. I'll check it and commit it on myfaces soon.<br><br>regards,<br><br>Leonardo Uribe<br> </div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<font color="#888888">
Andy<br>
<br>
</font></blockquote></div><br>