<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html;charset=ISO-8859-1" http-equiv="Content-Type">
</head>
<body bgcolor="#ffffff" text="#000000">
On 10/28/10 3:22 AM, Ed Burns wrote:
<blockquote cite="mid:19657.9413.199922.375934@gargle.gargle.HOWL"
type="cite">
<blockquote type="cite">
<blockquote type="cite">
<blockquote type="cite">
<blockquote type="cite">
<blockquote type="cite">
<pre wrap="">On Wed, 20 Oct 2010 18:32:56 -0400, Andy Schwartz <a class="moz-txt-link-rfc2396E" href="mailto:andy.schwartz@oracle.com"><andy.schwartz@oracle.com></a> said:
</pre>
</blockquote>
</blockquote>
</blockquote>
</blockquote>
</blockquote>
<pre wrap=""><!---->
AS> I have attached a patch to issue 893 that implements these changes. See:
I have reviewed and applied the most recent patch for 893 that is
attached to the issue (take3). I see no reason not to commit it so I'll
do so presently.
</pre>
</blockquote>
<br>
Awesome!<br>
<br>
<blockquote cite="mid:19657.9413.199922.375934@gargle.gargle.HOWL"
type="cite">
<pre wrap="">
Leonardo, In your opinion, do we need to make any changes to
NavigationHandler so that the new ViewDeclarationLanguage.viewExists()
method is consulted? I would expect this might need to be done.
</pre>
</blockquote>
<br>
Oh, woops - yep. ConfigurableNavigationHandler implementations should
use VDL.viewExists() instead of ExternalContext.getResource() to test
for view existence when determining whether implicit navigation is
possible. Actually, any place where we were using
ExternalContext.getResource() to check for a physical view needs to go
through VDL.viewExists() now. I believe that
ViewHandler.deriveViewId() and implicit navigation are the only 2
places where this comes up, though I will double check that later today.<br>
<br>
<blockquote cite="mid:19657.9413.199922.375934@gargle.gargle.HOWL"
type="cite">
<pre wrap="">
Andy, for completeness, don't we need to implement viewExists() for JSP?
</pre>
</blockquote>
<br>
In the patch that I provided, I included a concrete implementation of
viewExists() in ViewDeclarationLanguage - one that calls
ExternalContext.getResource(). This is sufficient for
JspViewHandlingStategy, which inherits this implementation.<br>
<br>
<blockquote cite="mid:19657.9413.199922.375934@gargle.gargle.HOWL"
type="cite">
<pre wrap="">
In any case, I've committed revision 8686 with this fix, and also made
the necessary spec changes, to the Frame document as well.
</pre>
</blockquote>
<br>
Great news. Thanks Ed!<br>
<br>
Andy<br>
<br>
<blockquote cite="mid:19657.9413.199922.375934@gargle.gargle.HOWL"
type="cite">
<pre wrap="">
Ed
</pre>
</blockquote>
<br>
</body>
</html>