Hi<br><br><div class="gmail_quote">2010/10/28 Ed Burns <span dir="ltr"><<a href="mailto:edward.burns@oracle.com">edward.burns@oracle.com</a>></span><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
EB> Leonardo, In your opinion, do we need to make any changes to<br>
EB> NavigationHandler so that the new ViewDeclarationLanguage.viewExists()<br>
EB> method is consulted? I would expect this might need to be done.<br>
<br></blockquote><div><br>In jsf 2.0, ViewHandler.deriveViewId check if the viewId exists or not to allow<br>ConfigurableNavigationHandler to work as expected. The difference between<br>ViewHandler.deriveViewId and the new ViewHandler.deriveLogicalViewId is that<br>
the second one does not do that change. Looks this code committed on <br>MultiViewHandler:<br><br> @Override<br> public String deriveViewId(FacesContext context, String rawViewId) {<br><br> return derivePhysicalViewId(context, rawViewId, true);<br>
<br> }<br><br> @Override<br> public String deriveLogicalViewId(FacesContext context, String rawViewId) {<br><br> return derivePhysicalViewId(context, rawViewId, false);<br><br> }<br><br>If ConfigurableNavigationHandler uses deriveLogicalViewId, my answer is yes,<br>
in my opinion VDL.viewExists() should be called from ConfigurableNavigationHandler.<br>There is no call for ExternalContext.getResource() from instances of <br>ConfigurableNavigationHandler.<br><br>regards,<br><br>Leonardo Uribe<br>
</div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
AS> Oh, woops - yep. ConfigurableNavigationHandler implementations<br>
AS> should use VDL.viewExists() instead of ExternalContext.getResource()<br>
AS> to test for view existence when determining whether implicit<br>
AS> navigation is possible. Actually, any place where we were using<br>
AS> ExternalContext.getResource() to check for a physical view needs to<br>
AS> go through VDL.viewExists() now. I believe that<br>
AS> ViewHandler.deriveViewId() and implicit navigation are the only 2<br>
AS> places where this comes up, though I will double check that later<br>
AS> today.<br>
<br>
OK, I have reopened the issue and will assign it to you. Please attach<br>
a patch to the issue and send it to <a href="mailto:dev@javaserverfaces.dev.java.net">dev@javaserverfaces.dev.java.net</a> for<br>
review. When I review the patch, I'll make the necessary changes to the<br>
spec PDF document.<br>
<br>
Ed<br>
<font color="#888888"><br>
--<br>
| <a href="mailto:edward.burns@oracle.com">edward.burns@oracle.com</a> | office: +1 407 458 0017<br>
| homepage: | <a href="http://ridingthecrest.com/" target="_blank">http://ridingthecrest.com/</a><br>
| 9 work days until German Oracle User's Group Conference<br>
</font></blockquote></div><br>