[keycloak-dev] default roles changes

Bill Burke bburke at redhat.com
Wed Nov 6 12:36:50 EST 2013


Yup

On 11/6/2013 12:34 PM, Stian Thorgersen wrote:
> Fixed it? You mean you would have just gone and changed the work I did without even talk to me about it first?
>
> ----- Original Message -----
>> From: "Bill Burke" <bburke at redhat.com>
>> To: "Stian Thorgersen" <stian at redhat.com>
>> Cc: keycloak-dev at lists.jboss.org
>> Sent: Wednesday, 6 November, 2013 5:31:00 PM
>> Subject: Re: [keycloak-dev] default roles changes
>>
>> I would have fixed it as there are tests that depend on it, but I was
>> too tired to do it last night.
>>
>> On 11/6/2013 12:28 PM, Stian Thorgersen wrote:
>>> Well that's just an absolutely smashing way of dealing with it! You could
>>> have asked me why it was done that way, and then we could have discussed
>>> how to do it! Not just rip out something that was working!
>>>
>>> ----- Original Message -----
>>>> From: "Bill Burke" <bburke at redhat.com>
>>>> To: keycloak-dev at lists.jboss.org
>>>> Sent: Wednesday, 6 November, 2013 2:34:13 AM
>>>> Subject: [keycloak-dev] default roles changes
>>>>
>>>> I'm trying to resolve merge conflicts and came across the new default
>>>> roles changes.
>>>>
>>>> Why are you adding default roles to tokens?  This is just not correct
>>>> and not the way we should be doing things.  Instead, default roles
>>>> should be used to populate user role mappings when a user is created.
>>>>
>>>> I'm removing the token population code you ahve.
>>>> --
>>>> Bill Burke
>>>> JBoss, a division of Red Hat
>>>> http://bill.burkecentral.com
>>>> _______________________________________________
>>>> keycloak-dev mailing list
>>>> keycloak-dev at lists.jboss.org
>>>> https://lists.jboss.org/mailman/listinfo/keycloak-dev
>>>>
>>
>> --
>> Bill Burke
>> JBoss, a division of Red Hat
>> http://bill.burkecentral.com
>>

-- 
Bill Burke
JBoss, a division of Red Hat
http://bill.burkecentral.com


More information about the keycloak-dev mailing list