[keycloak-dev] Still some broker work to do

[Stian Thorgersen]

----- Original Message -----
> From: "Marek Posolda" <mposolda at redhat.com>
> To: "Bill Burke" <bburke at redhat.com>, keycloak-dev at lists.jboss.org
> Sent: Wednesday, March 18, 2015 5:01:41 PM
> Subject: Re: [keycloak-dev] Still some broker work to do
> 
> On 18.3.2015 14:55, Bill Burke wrote:
> > You may want to hold back on the migration stuff for a day.  I'm going
> > to remove the IdentityProviderModel.name attribute as it is redundant,
> > rename 'id' to 'alias' and 'internalId' to 'id'.  Also going to
> > hardcode the social aliases to 'facebook', 'twitter', etc. and remove
> > this as a field for configuring social.
> +1, looks much better than having 3 id fields on IdentityProviderModel.
> Also how about renaming 'providerId' to 'providerType' ? This points to
> type (like 'facebook', 'google' etc), so providerId looks a bit
> misleading to me.

I'd say leave it as providerId as that's what it's called in ProviderFactory

> 
> Marek
> > Blocker bug is that logout is totally broken.    SAML worked
> > yesterday, not sure after your changes.  I'll test and fix any
> > remaining issues with brokers.
> >
> > On 3/18/2015 9:45 AM, Marek Posolda wrote:
> >> I've removed option for enable/disable identity provider per application
> >> ( https://issues.jboss.org/browse/KEYCLOAK-1108 ) and fixed facebook,
> >> google and twitter examples with keycloak-appliance. I did not test SAML
> >> broker though.
> >>
> >> Now after rebase, I figured that it's not possible to create any
> >> identity provider in admin console. Is it the blocker you mean?
> >>
> >> I am looking at migration stuff now.
> >>
> >> Marek
> >>
> >> On 18.3.2015 14:16, Bill Burke wrote:
> >>> There's still some broker work to do before release.  There's one or
> >>> more blocker bugs and logout doesn't work.  The UI is quirky and there
> >>> is some redundant metadata.
> >>>
> >>
> >
> 
> _______________________________________________
> keycloak-dev mailing list
> keycloak-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/keycloak-dev
>