[keycloak-dev] Japanese Localization

[Hiroyuki Wada]

I created a JIRA issue. I will send a PR soon.

https://issues.jboss.org/browse/KEYCLOAK-3435

2016年8月16日(火) 18:16 Stian Thorgersen <sthorger at redhat.com>:

> Sure
>
> On 16 August 2016 at 10:53, Hiroyuki Wada <wadahiro at gmail.com> wrote:
>
>> By the way, I found some minor issues in UI like missing message key
>> during this translation work.
>> Could I create a JIRA issue and send a PR?
>>
>> Regards,
>>
>> --
>> Hiroyuki Wada
>>
>> On Fri, Aug 5, 2016 at 10:13 AM, Hiroyuki Wada <wadahiro at gmail.com>
>> wrote:
>> >> Just a note that we can accept localization PR if you also take care of
>> >> maintain your locale in future releases.
>> >
>> > Yes, I will maintain it.
>> >
>> > Regards,
>> >
>> > --
>> > Hiroyuki Wada
>> >
>> >
>> > On Thu, Aug 4, 2016 at 5:02 PM, Marek Posolda <mposolda at redhat.com>
>> wrote:
>> >> Just a note that we can accept localization PR if you also take care of
>> >> maintain your locale in future releases.
>> >>
>> >> Thanks,
>> >> Marek
>> >>
>> >>
>> >> On 04/08/16 03:46, Hiroyuki Wada wrote:
>> >>
>> >> Thanks. I created a JIRA issue.
>> >> https://issues.jboss.org/browse/KEYCLOAK-3397
>> >>
>> >> I'll send a pull request later!
>> >>
>> >>
>> >> 2016年8月3日(水) 17:05 Thomas Darimont <thomas.darimont at googlemail.com>:
>> >>>
>> >>> Hello Hiroyuki,
>> >>>
>> >>> I'd say just go ahead and feel free to create a JIRA issue - and
>> reference
>> >>> the issue number in your commit like
>> >>> KEYCLOAK-XXX Add Japanese localization.
>> >>>
>> >>> Try to keep your changes in a single commit in your pull request, this
>> >>> makes it easier to apply (e.g. via cherry-pick) - I listed my
>> workflow for
>> >>> reference below.
>> >>> Once you're done with your PR just add a link to it to the JIRA issue
>> (in
>> >>> the JIRA issue, press "." then type "git" -> which brings you the to
>> the
>> >>> "add git pull request" dialog.
>> >>>
>> >>> If you want an example for a JIRA issue here is a similar ticket for
>> >>> french translation:
>> >>> https://issues.jboss.org/browse/KEYCLOAK-1903
>> >>>
>> >>> Cheers,
>> >>> Thomas
>> >>>
>> >>> My workflow:
>> >>> I tend to create a separate branch for every JIRA issue, so I do the
>> >>> following (from a checked out master branch)
>> >>> 0) git clone https://github.com/thomasdarimont/keycloak
>> >>>     (origin is my keycloak fork)
>> >>>     git remote add upstream https://github.com/keycloak/keycloak
>> >>>     (upstream is original keycloak)
>> >>> 1) git checkout -b issue/KEYCLOAK-XXX-short-description
>> >>> (this will create and checkout the branch)
>> >>> 2) code...
>> >>> 3) git add .
>> >>> 4) git commit -m (or use a graphical git client like gitg on linux, or
>> >>> gitx on osx)
>> >>> 5) git push -u origin issue/KEYCLOAK-XXX-short-description
>> >>> 6) on your cloned github project you should now see a link for: create
>> >>> pull request for the newly pushed branch - click and the PR is there
>> >>> if I need to change stuff in the PR (before it is merged) I do the
>> >>> following
>> >>> 7) change...
>> >>> 8) git add .
>> >>> 9) git commit --amend (or use a graphical git client like gitg on
>> linux,
>> >>> or gitx on osx)
>> >>> 10) git push -f origin issue/KEYCLOAK-XXX-short-description
>> >>> (this will update your PR as well, but github is smart enough to
>> retain
>> >>> potentially PR comments if those places didn't change)
>> >>> 11) goto 7) if necessary
>> >>>
>> >>> Updating your keycloak fork from original keycloak upstream
>> >>> 1) git checkout master
>> >>> 2) git pull upstream master
>> >>> 3) git push origin master
>> >>> (to update the master branch in your fork if necessary)
>> >>>
>> >>> to update an issue branch to the latest master
>> >>> 1) git checkout issue/KEYCLOAK-XXX-short-description
>> >>> 2) git rebase master
>> >>> (your issue branch is now based on the latest changes from master)
>> >>> 3) git push -f origin issue/KEYCLOAK-XXX-short-description
>> >>>
>> >>> 2016-08-03 5:19 GMT+02:00 Hiroyuki Wada <wadahiro at gmail.com>:
>> >>>>
>> >>>> Hello all,
>> >>>>
>> >>>> I am translating all base theme messages to Japanaese language now.
>> >>>> (I think I can do it by the end of the week.)
>> >>>>
>> >>>> I'd like to contribute the message resources, How do you think?
>> >>>> If it's ok, I'll create a JIRA issue and create a pull request.
>> >>>>
>> >>>> Regards,
>> >>>>
>> >>>> --
>> >>>> Hiroyuki Wada
>> >>>> wadahiro at gmail.com
>> >>>>
>> >>>> _______________________________________________
>> >>>> keycloak-dev mailing list
>> >>>> keycloak-dev at lists.jboss.org
>> >>>> https://lists.jboss.org/mailman/listinfo/keycloak-dev
>> >>>
>> >>>
>> >>
>> >>
>> >> _______________________________________________
>> >> keycloak-dev mailing list
>> >> keycloak-dev at lists.jboss.org
>> >> https://lists.jboss.org/mailman/listinfo/keycloak-dev
>> >>
>> >>
>>
>> _______________________________________________
>> keycloak-dev mailing list
>> keycloak-dev at lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/keycloak-dev
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.jboss.org/pipermail/keycloak-dev/attachments/20160816/00e77ac1/attachment.html