[keycloak-dev] Need to remove built-in themes from standalone/configuration/themes

[Bill Burke]

Keep it the way it is, IMO.  Write directions on how to handle a theme 
patch.

On 2/12/2016 11:01 AM, Stan Silvert wrote:
> Another way to deal with this might be to unjar the files ourselves at 
> startup.  The files could live in the same place they live today.
>
> We would just have keep track of versioning.  If a newer version of 
> the theme is installed we overwrite the old version in 
> standlone/configuration/themes.  Of course, if the theme has been 
> modified by the user we wouldn't overwrite, but instead just unjar to 
> another location.
>
> On 2/12/2016 9:44 AM, Stian Thorgersen wrote:
>>
>> Currently we include built-in themes in the themes jar as well as 
>> extracted to standalone/configuration/themes. We have to remove the 
>> extracted files.
>>
>> This is due to patching. The patching tools only supports patching 
>> modules, not files. If we need to patch the theme templates (quite 
>> likely we will) we can then only patch the jar. As the extracted 
>> themes override the jar it won't work unless we remove them.
>>
>> The main problem with removing the extracted files is that they are 
>> useful for someone that needs to modify the templates. I think the 
>> best would just be to give people instructions on how to extract 
>> these from the jar. It's just a zip after all.
>>
>> Thoughts??
>>
>>
>>
>> _______________________________________________
>> keycloak-dev mailing list
>> keycloak-dev at lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/keycloak-dev
>
>
>
> _______________________________________________
> keycloak-dev mailing list
> keycloak-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/keycloak-dev

-- 
Bill Burke
JBoss, a division of Red Hat
http://bill.burkecentral.com

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.jboss.org/pipermail/keycloak-dev/attachments/20160212/f2c412c2/attachment-0001.html