[keycloak-dev] Enable JDK8 for testsuite

Stian Thorgersen sthorger at redhat.com
Mon May 9 01:19:45 EDT 2016


I'm dropping JDK8 for now. In the future we'll have this issue again at
some point though as we will eventually allow server only modules to use
Java8 features.

On 6 May 2016 at 07:15, Stian Thorgersen <sthorger at redhat.com> wrote:

> I'm afraid I've already merged this. I could change it back, but in the
> future we will start using JDK8 features on the server side, that means all
> modules not used by adapters will be allowed to use JDK8 features. It seems
> like a better way forward would be to solve the issue (my PermissionsTests
> will be horrible without lambdas as well).
>
> Why are the servlets in "tests/base" at all? Seems like these are only
> used by "tests/other/adapters" and that's where they should be. Base should
> focus on only testing the server itself. If the servlets are moved there we
> can make only "tests/base" use JDK8. That would solve the problem right?
>
> On 5 May 2016 at 11:46, Michal Hajas <mhajas at redhat.com> wrote:
>
>> Hi Stian,
>>
>> I think we may have problem with this, because our servlets are in base
>> testsuite (
>> https://github.com/keycloak/keycloak/tree/master/testsuite/integration-arquillian/tests/base/src/main/java/org/keycloak/testsuite/adapter/servlet)
>> and they need to be compiled with java 7. We need to be able to deploy them
>> to containers running on java 7. Will be these files involved too?
>>
>> Michal.
>>
>> ----- Original Message -----
>> > From: "Stian Thorgersen" <sthorger at redhat.com>
>> > To: "keycloak-dev" <keycloak-dev at lists.jboss.org>
>> > Sent: Tuesday, May 3, 2016 1:05:12 PM
>> > Subject: [keycloak-dev] Enable JDK8 for testsuite
>> >
>> > I've changed source/target to 1.8 for testsuite/integration-arquillian.
>> This
>> > is so I can use lambdas for testing permissions (otherwise I end up with
>> > extremely messy tests with loads of anonymous inner classes).
>> >
>> > Anyone have any issues with that?
>> >
>> > In 2.x we can look at setting 1.8 as default for everything except
>> adapters
>> > and shared modules.
>> >
>> > _______________________________________________
>> > keycloak-dev mailing list
>> > keycloak-dev at lists.jboss.org
>> > https://lists.jboss.org/mailman/listinfo/keycloak-dev
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.jboss.org/pipermail/keycloak-dev/attachments/20160509/a75d924c/attachment.html 


More information about the keycloak-dev mailing list