[keycloak-dev] Strip default port from URLs in KeycloakUriBilder

[Sebastien Blanc]

Make sense to me

On Fri, Dec 1, 2017 at 9:39 AM, Stian Thorgersen <sthorger at redhat.com>
wrote:

> I've sent a PR [1] that strips default ports (80 if http, 443 if https)
> from the URL in KeycloakUriBuilder. This is to make sure URLs matches URLs
> in browsers (browsers already do this) and also strips default ports from
> adapter configs which resolves [2].
>
> [2] although strictly bad config is nice to be able to do if you have a
> keycloak.json file that takes the port from environment variables to for
> instance run on 8080 in test and 80 in prod.
>
> Anyone have any concerns with this PR?
>
> [1] https://github.com/keycloak/keycloak/pull/4774
> [2] https://issues.jboss.org/browse/KEYCLOAK-5945
> _______________________________________________
> keycloak-dev mailing list
> keycloak-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/keycloak-dev
>