[keycloak-dev] Allow AdminEvents for custom resource types

Stian Thorgersen sthorger at redhat.com
Wed Feb 20 05:42:20 EST 2019


We can't accept the PR as is due to it breaking backwards compatibility of
the API.

Can you elaborate on your use-case? I'm far from convinced we should
support this level of customisation.

On Wed, 20 Feb 2019, 05:32 Lösch, Sebastian, <Sebastian.Loesch at governikus.de>
wrote:

> Hello devs,
>
> we implemented a custom resource type as an extension to keycloak.
> For traceability reasons we would like to track actions for this custom
> resource type via AdminEvents.
> Unfortunately the resource type is represented by the enum ResourceType.
> Therefore no AdminEvents for custom non standard resource types can be
> created.
> It would be nice if it is possible to specify the resource type as string
> value also.
>
> This is only a small change, because the resource type is only provided
> via enum but handled as string value internally.
> I provided a pull request for that enhancement:
> https://github.com/keycloak/keycloak/pull/5882
>
> May anybody have a look on that review?
>
> Best regards,
> Sebastian
>
>
>
> _______________________________________________
> keycloak-dev mailing list
> keycloak-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/keycloak-dev
>


More information about the keycloak-dev mailing list