<html>
<head>
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
<p>
Hi all,<br>
</p>
<p>
So, I've looked at both - the code and the console UI. I've
created bunch of JIRAs today and I still have some unclear issues.
Here's my list:<br>
</p>
<p>
</p>
<ul>
<li>What's the point of admin-ui-styles module? Why does it
contain html?</li>
<ul>
<li>I had troubles with this when I was working on the social
page and some (provider helper) pages were used from this
module instead of admin-ui module.</li>
</ul>
</ul>
<p>
</p>
<ul>
<li>Directive naming not unified (ie. uncollapsed vs. kcInput).</li>
<ul>
<li>Do we care about that (it's angularJS good practice)? I
think it would be not just correct but even pretty to have kc
prefix everywhere.</li>
</ul>
</ul>
<p>
</p>
<ul>
<li>I see combined AngularJS + JQuery code on some places.</li>
<ul>
<li>AFAIK this should be avoided unless there is no angular way
how to solve the problem.</li>
</ul>
</ul>
<p>
</p>
<ul>
<li>Array.prototype.remove from controller.js used only on one
(mine) place, on other places we use .splice to remove from
array.</li>
<ul>
<li>Why was this method created? What's the advantage when
compared to splice?</li>
</ul>
</ul>
<p>
</p>
<ul>
<li>Lots of warnings in the JS code (like herd of unused $q in
loaders.js).</li>
</ul>
<p>
</p>
<ul>
<li>They way the menu (<ul class="rcue-tabs">) / breadcrums
is generated (hardcoded on each page) results in big amount of
redundant code (this bothers me a lot).</li>
<ul>
<li>One of the actual consequences of this is - if you traverse
through realm settings for most pages the "settings" line/tab
on the left is highlighted, but for some (registration, keys)
it's not.</li>
<li>If you add new page, you have to update the menu on many
other pages and you can easily miss some as in the situation
above.</li>
</ul>
</ul>
<p>
</p>
<ul>
<li>Missing l18n.</li>
</ul>
<p>
</p>
<ul>
<li>Credentials page for user is missing.</li>
</ul>
<p>
</p>
<ul>
<li>Session pages for "Applications" part are missing.</li>
</ul>
<p>
</p>
<ul>
<li>Manage account of the logged-in user is missing.</li>
<ul>
<li>Clicking on the "manage account" in logged-in user menu (top
right) does nothing.</li>
</ul>
</ul>
<p>
And the nitpicker bonus:<br>
</p>
<p>
</p>
<ul>
<li>What about using the maven-checkstyle-plugin? :)</li>
</ul>
<p>
Thanks for your thoughts on this,<br>
</p>
<p>
Viliam</p>
<meta name="Description" content="Copy-Paste Buffer">
<meta name="Generator" content="Zim">
</body>
</html>