<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">A couple of other things I failed to
mention.<br>
<br>
On 1/30/2014 9:59 AM, <a class="moz-txt-link-abbreviated" href="mailto:ssilvert@redhat.com">ssilvert@redhat.com</a> wrote:<br>
</div>
<blockquote cite="mid:52EA68CA.800@redhat.com" type="cite">
<pre wrap="">Future tasks for the Keycloak Subsystem:
* Integration with the Keycloak Admin
* Review the attributes of realm and secure-deployment to make sure they
align with keycloak.json.</pre>
</blockquote>
And also make sure that default boolean values are correct. Make
sure required fields are correctly marked as such. Etc.<br>
<blockquote cite="mid:52EA68CA.800@redhat.com" type="cite">
<pre wrap="">
* Fill in help text in
keycloak/subsystem/src/main/resources/org/keycloak/subsystem/extension/LocalDescriptions.properties
* See comments in KeycloakAdapterConfigService.java. This class may
work better as a plain Singleton instead of a service.</pre>
</blockquote>
And also this class is not currently thread-safe. We could probably
get by with just making all the public methods synchronized. The
rare case where thread safety matters is when two administrators are
editing the subsystem at the same time. At startup, the
initialization of all the data is single-threaded.<br>
<blockquote cite="mid:52EA68CA.800@redhat.com" type="cite">
<pre wrap="">
* It probably wouldn't hurt to ask Brian Stansberry to give the
subsystem a quick review.
* More tests
* Package the subsystem with the distribution
* Documentation
</pre>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
keycloak-dev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:keycloak-dev@lists.jboss.org">keycloak-dev@lists.jboss.org</a>
<a class="moz-txt-link-freetext" href="https://lists.jboss.org/mailman/listinfo/keycloak-dev">https://lists.jboss.org/mailman/listinfo/keycloak-dev</a></pre>
</blockquote>
<br>
</body>
</html>