<div dir="ltr">No problem at all. Would you guys like to have the codebase under keycloak organization? Just let me know.</div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Dec 5, 2014 at 6:23 AM, Stian Thorgersen <span dir="ltr"><<a href="mailto:stian@redhat.com" target="_blank">stian@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">There's benefits to both approaches, but the simple fact is we currently version everything the same. Keycloak, adapters, cartridges, etc. I don't want to have a special case for the Passport adapter, so let's use the same version at least for now.<br>
<span class="im HOEnZb"><br>
----- Original Message -----<br>
> From: "Bruno Oliveira" <<a href="mailto:bruno@abstractj.org">bruno@abstractj.org</a>><br>
</span><span class="im HOEnZb">> To: "Bill Burke" <<a href="mailto:bburke@redhat.com">bburke@redhat.com</a>><br>
> Cc: <a href="mailto:keycloak-dev@lists.jboss.org">keycloak-dev@lists.jboss.org</a><br>
> Sent: Thursday, 4 December, 2014 5:01:41 PM<br>
> Subject: Re: [keycloak-dev] Invalid redirect_uri with passport<br>
><br>
</span><div class="HOEnZb"><div class="h5">> On 2014-12-04, Bill Burke wrote:<br>
> ><br>
> ><br>
> > On 12/4/2014 10:04 AM, Lucas Holmquist wrote:<br>
> > ><br>
> > >>On Dec 4, 2014, at 9:56 AM, Bill Burke <<a href="mailto:bburke@redhat.com">bburke@redhat.com</a>> wrote:<br>
> > >><br>
> > >><br>
> > >><br>
> > >>On 12/4/2014 9:19 AM, Bruno Oliveira wrote:<br>
> > >>>On 2014-12-04, Bill Burke wrote:<br>
> > >>>>I'd like to distribute this in the next release and document it. Will<br>
> > >>>>the appropriate Node.js distribution methods be available for this?<br>
> > >>>>(Bower?)<br>
> > >>><br>
> > >>>Hi Bill, it's distributed under npm here<br>
> > >>><a href="https://www.npmjs.org/package/passport-keycloak" target="_blank">https://www.npmjs.org/package/passport-keycloak</a><br>
> > >>><br>
> > >>>>Change the version to 1.1.Beta2 :)<br>
> > >>><br>
> > >>>I'm not so sure about the versioning, it's a big bump for the first<br>
> > >>>release. But I'm fine if you guys think the opposite.<br>
> > >>><br>
> > >><br>
> > >>Doesn't matter. Have it same version as Keycloak. It will be easier to<br>
> > >>keep track of compatibilities for both us and users. BTW, our Tomcat<br>
> > >>and Jetty are new, we didn't version it 0.0.alph1. :)<br>
> > ><br>
> > >i sort of disagree here. This is just an adapter really, and should be on<br>
> > >it’s own versioning independent of what the main key cloak distribution<br>
> > >is.<br>
> > ><br>
> ><br>
> > In my experience different versions just confuses people. It starts to<br>
> > become important when you have multiple major versions out in the wild and<br>
> > there are incompatibilities between them.<br>
><br>
> Bill, my major concern about having the same versioning. Is people<br>
> mistakenly assuming that this adapter is full compatible with all the<br>
> features on<br>
> Keycloak, which is not true at the moment. More work is required, like<br>
> you asked for role mappings, bearer tokens and etc.<br>
><br>
> Does it make sense to you?<br>
><br>
> ><br>
> ><br>
> > --<br>
> > Bill Burke<br>
> > JBoss, a division of Red Hat<br>
> > <a href="http://bill.burkecentral.com" target="_blank">http://bill.burkecentral.com</a><br>
><br>
> --<br>
><br>
> abstractj<br>
> PGP: 0x84DC9914<br>
</div></div><div class="HOEnZb"><div class="h5">> _______________________________________________<br>
> keycloak-dev mailing list<br>
> <a href="mailto:keycloak-dev@lists.jboss.org">keycloak-dev@lists.jboss.org</a><br>
> <a href="https://lists.jboss.org/mailman/listinfo/keycloak-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/keycloak-dev</a><br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature"><div><br></div>-- <br>"The measure of a man is what he does with power" - Plato<br>-<br>@abstractj<br>-<br>Volenti Nihil Difficile</div>
</div>