<div dir="ltr">Hello there,<br><div><div class="gmail_extra"><br><div class="gmail_quote">2015-08-10 10:04 GMT+02:00 Stian Thorgersen <span dir="ltr"><<a href="mailto:stian@redhat.com" target="_blank">stian@redhat.com</a>></span>:<span class=""></span><br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">
<br>
</span>The code base is already centered as modules, but we'll probably change things somewhat to make public api/spis stand out more. We won't document or add Javadoc to any parts of the code base that aren't public api/spis.<span class=""><br></span></blockquote><div><br></div><div>I believe that some implementation details which carry over into the model/configuration domain (i.e. semantics of configuration or implementation details) should likely be documented for clarity - even if they are not part of APIs or SPIs. However, I can appreciate that these types of changes or documentation have less priority than other tasks. We all work in some kind of sprint context where priorities have to be made.<br><br>:)<br></div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">
> ... and while digging into the codebase, I found some things that I wanted<br>
> to share and possibly contribute, partly because I found it somewhat<br>
> difficult to understand how the configuration related to the file system.<br>
> Also, some best practises were not touched upon in documentation or<br>
> examples - and while that is understandable considering that KeyCloak is a<br>
> project, I figured I could perhaps submit a suggestion [in the form of a<br>
> GitHub pull request] for simplifying somewhat.<br>
<br>
</span>Sure - I'd welcome improvements, but please write an email top keycloak-dev mailing list outlining each improvement before working on a PR. Refactoring of the code should be done with great consideration as it makes life hard for existing developers and contributors when things change.<br><div class="HOEnZb"><div class="h5"></div></div></blockquote><div><br></div><div>I agree; it is important that changes constitute improvements overall.<br></div><div><br>I'll ponder, create a JIRA issue and do the changes in my private KeyCloak fork - it can be discussed and dissected there rather than in the KeyCloak standard repository. <br></div></div><br>-- <br><div class="gmail_signature"><span style="font-family:monospace;font-size:medium"><pre>--
+==============================+
| Bästa hälsningar,
| [sw. "Best regards"]
|
| Lennart Jörelid
| EAI Architect & Integrator
|
| jGuru Europe AB
| Mölnlycke - Kista
|
| Email: <a href="mailto:lj@jguru.se" target="_blank">lj@jguru.se</a>
| URL: <a href="http://www.jguru.se" target="_blank">www.jguru.se</a>
| Phone
| (skype): jgurueurope
| (intl): +46 708 507 603
| (domestic): 0708 - 507 603
+==============================+</pre></span></div>
</div></div></div>