<div dir="ltr">Merged - as I said in the PR could you do the same for registration? It looks like the correct approach to me. Would be great if you could also add tests?</div><div class="gmail_extra"><br><div class="gmail_quote">On 8 October 2015 at 20:47, Sebastian Rose <span dir="ltr"><<a href="mailto:sebastian.rose@aoe.com" target="_blank">sebastian.rose@aoe.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div lang="DE" link="blue" vlink="purple">
<div><span class="">
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d">Here is the PR for just KEYCLOAK-1927:
<a href="https://github.com/keycloak/keycloak/pull/1689" target="_blank">https://github.com/keycloak/keycloak/pull/1689</a><u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d"><u></u> <u></u></span></p>
</span><p class="MsoNormal"><b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">Von:</span></b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"> Stian Thorgersen [mailto:<a href="mailto:sthorger@redhat.com" target="_blank">sthorger@redhat.com</a>]
<br><span class="">
<b>Gesendet:</b> Donnerstag, 8. Oktober 2015 19:25<br>
<b>An:</b> Sebastian Rose<br>
<b>Cc:</b> <a href="mailto:keycloak-dev@lists.jboss.org" target="_blank">keycloak-dev@lists.jboss.org</a><br>
<b>Betreff:</b> Re: [keycloak-dev] Direct link to registration/forgot-credentials<u></u><u></u></span></span></p>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<p class="MsoNormal">I'm happy with adding the f<span style="font-size:9.5pt">orgot-credentials link, but not 100% sure about what's the correct approach. Can you prepare a separate PR for just KEYCLOAK-1927 so we can review it?</span><u></u><u></u></p><div><div class="h5">
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:9.5pt">We can add it as an option to the js-console, but I don't want to add forgotCredentials and createForgotCredentialsUrl, nor do I want to add it to the js-console. Basically I don't really want to advocate this
approach.</span><u></u><u></u></p>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
</div>
</div></div></div><div><div class="h5">
<div>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<p class="MsoNormal">On 8 October 2015 at 19:14, Sebastian Rose <<a href="mailto:sebastian.rose@aoe.com" target="_blank">sebastian.rose@aoe.com</a>> wrote:<u></u><u></u></p>
<blockquote style="border:none;border-left:solid #cccccc 1.0pt;padding:0cm 0cm 0cm 6.0pt;margin-left:4.8pt;margin-right:0cm">
<p class="MsoNormal">Hi all,<br>
<br>
i have a requirement to provide an external link for register account and forgot-credentials.<br>
<br>
I learned from KEYCLOAK-1904 that using .../openid-connect/registrations?client_id=.... instead auf /openid-connect/auth?client_id=... works for the register account part. KEYCLOAK-1904 brought this to the js-adapter and provided it as an example to js-console.
While testing that KEYCLOAK-1910 was created due to a problem with the bean-initialization.<br>
<br>
For having the same with forgot-credentials i added simmilar code to make .../openid-connect/forgot-credentials?client_id=... work. This change is described in KEYCLOAK-1927.<br>
<br>
My first approach was not considering the Authorization SPI (thanks Stian). Second approach uses the class AuthenticationProcessor which is already used for .../openid-connect/auth to make KEYCLOAK-1910 and KEYCLOAK-1927 work. I am not sure if i understood
completely and any hint/help is appreciated. With some manual tests it worked fine (please see
<a href="https://github.com/keycloak/keycloak/pull/1686" target="_blank">https://github.com/keycloak/keycloak/pull/1686</a>)<br>
<br>
Please let me know what you think:<br>
1) .../openid-connect/forgot-credentials is something you can live with/find it usefull<br>
2) Is using class AuthenticationProcessor the correct approach . Anything there to consider after the call of .authenticate? There is a lot more code in place for the auth-case, which deals with variants. They don't seem to be useful for the two other cases.<br>
3) I would like to add .../openid-connect/forgot-credentials to the js-adapter and js-console as well.<br>
<br>
Best Regards,<br>
Sebastian<br>
<br>
_______________________________________________<br>
keycloak-dev mailing list<br>
<a href="mailto:keycloak-dev@lists.jboss.org" target="_blank">keycloak-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/keycloak-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/keycloak-dev</a><u></u><u></u></p>
</blockquote>
</div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
</div></div></div>
</div>
</blockquote></div><br></div>