<div dir="ltr">We should just go ahead an improve the admin api. Then we make sure this is used when testing. Anyone doing changes to the admin endpoints should in the future write tests for it, which should use the admin api.</div><div class="gmail_extra"><br><div class="gmail_quote">On 21 October 2015 at 11:16, Marek Posolda <span dir="ltr"><<a href="mailto:mposolda@redhat.com" target="_blank">mposolda@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF">
<div>The nicer API will be good, but IMO it
is more important the REST endpoints are up-to-date . Which is not
the case now. I believe the autogeneration will help with having
the admin-client endpoints synced with the stuff from server. <br>
<br>
Unfortunately it seems to me that it will be challenge to have
nice API and autogeneration at the same time <span><span> :-\ </span></span><br><span class="HOEnZb"><font color="#888888">
<br>
Marek</font></span><div><div class="h5"><br>
<br>
On 21/10/15 09:40, Stian Thorgersen wrote:<br>
</div></div></div><div><div class="h5">
<blockquote type="cite">
<div dir="ltr">I don't like the use of RestEasy client for these
in the first place. It doesn't make a very nice Java library
IMO. Something like:
<div><br>
</div>
<div> void createRealm(RealmRepresentation rep) throws
AdminException</div>
<div><br>
</div>
<div>Would be much better than:</div>
<div><br>
</div>
<div> Response createRealm(RealmRepresentation rep)</div>
<div><br>
</div>
<div>Under the covers the implementation could use RestEasy
client, but I don't think the current approach creates a very
nice API.</div>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On 21 October 2015 at 09:31, Marek
Posolda <span dir="ltr"><<a href="mailto:mposolda@redhat.com" target="_blank">mposolda@redhat.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF"> Was wondering if
resteasy has some way to autogenerate REST endpoints
inside integration/admin-client to be automatically synced
with the REST endpoints from keycloak-services ?<br>
<br>
So for example when I add new REST endpoint on server-side
into org.keycloak.services.resources<span style="background-color:#e4e4ff"> .RealmsResource class,
the admin-client class </span>org.keycloak.admin.client.resource<span style="background-color:#e4e4ff"></span>.RealmsResource
will be automatically updated too . Ideally there can be
maven target executed on demand for update admin-client
sources. That would help to avoid unsynced endpoints in
admin-client - issues like <a href="https://issues.jboss.org/browse/KEYCLOAK-1967" target="_blank">https://issues.jboss.org/browse/KEYCLOAK-1967</a>
.<span><font color="#888888"><br>
<br>
Marek<br>
</font></span></div>
<br>
_______________________________________________<br>
keycloak-dev mailing list<br>
<a href="mailto:keycloak-dev@lists.jboss.org" target="_blank">keycloak-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/keycloak-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailman/listinfo/keycloak-dev</a><br>
</blockquote>
</div>
<br>
</div>
</blockquote>
<br>
</div></div></div>
</blockquote></div><br></div>