<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">We prefer integration tests as you
usually need more things to have available. For example for
federation, you need realm and user DB and you need to have realm
configured with federationProvider. There is not much you can test
within single module, so we have just very simple tests in
individual modules (like LDAPDnTest or PasswordPolicyTest), but
most of the stuff is tested in testsuite. For KEYCLOAK-1797 I
prefer to take a look at <span style="background-color:#e4e4ff;">LDAPRoleMappingsTest
and possibly add new test methods here.<br>
<br>
Btv. what's your plan for KEYCLOAK-1797 ? And in your LDAP
environment, is it often that new role is added as member to
some other roles? I wonder if we need to always do "deep" search
in runtime, or if we can instead do it just at some point and
rely on Keycloak composite roles . If you always need deep
search and do something based on it, it will be good to have a
flag in configuration, which will allow to disable it (for
performance reasons).<br>
<br>
Marek<br>
<br>
</span>On 26/10/15 08:55, Andrzej Goławski wrote:<br>
</div>
<blockquote
cite="mid:CAA0ckM496ZXf6wA3O8G2MaCcmntpY4vCB=Z-6yeJosF0WB3H8A@mail.gmail.com"
type="cite">
<div dir="ltr">
<div>Hi Marek,</div>
<div><br>
</div>
<div>Thanks for reply!</div>
<div>I saw those test, but personally I prefer unit tests over
integrated tests:)</div>
<div>I really recommend this: <a moz-do-not-send="true"
href="https://vimeo.com/80533536">https://vimeo.com/80533536</a></div>
<div><br>
</div>
<div>Best Regards,</div>
<div> Andrzej</div>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">2015-10-26 8:41 GMT+01:00 Marek Posolda
<span dir="ltr"><<a moz-do-not-send="true"
href="mailto:mposolda@redhat.com" target="_blank">mposolda@redhat.com</a>></span>:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF">
<div>Hi,<br>
<br>
most of the tests are in the testsuite/integration or
testsuite/integration-arquillian, not in the modules
itself. For the federation and ldap, you can take a look
especially to package org.keycloak.testsuite.federation
.<br>
<br>
Marek <br>
<div>
<div class="h5"> <br>
On 25/10/15 21:51, Andrzej Goławski wrote:<br>
</div>
</div>
</div>
<blockquote type="cite">
<div>
<div class="h5">
<div dir="ltr">
<div>Hi everyone!</div>
<div><br>
</div>
<div>I decided to implement KEYCLOAK-1797 and
started to look at the code (federation/ldap). I
noticed lack of unit tests without which
refactoring may be very error prone. I like
writing test so I can write tests for that part.
What are you thinking about it??</div>
<div><br>
</div>
<div>
<div>Best Regards,</div>
<div> Andrzej</div>
</div>
</div>
<br>
<fieldset></fieldset>
<br>
</div>
</div>
<pre>_______________________________________________
keycloak-dev mailing list
<a moz-do-not-send="true" href="mailto:keycloak-dev@lists.jboss.org" target="_blank">keycloak-dev@lists.jboss.org</a>
<a moz-do-not-send="true" href="https://lists.jboss.org/mailman/listinfo/keycloak-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/keycloak-dev</a></pre>
</blockquote>
<br>
</div>
</blockquote>
</div>
<br>
</div>
</blockquote>
<br>
</body>
</html>