<div dir="ltr">I'm quite concerned about auto linking accounts. If someone has loads of social networks enabled and a user has a single of those compromised (that happens quite frequently) the attackers would then also be able to gain access to whatever Keycloak secures. The user wouldn't even know they have access to Keycloak, since the user has never used to compromised account to login to Keycloak.<div><br></div><div>I strongly feel we should never link to any account without requiring user to first authenticate to the account we are linking with. </div></div><div class="gmail_extra"><br><div class="gmail_quote">On 27 October 2015 at 08:04, Marek Posolda <span dir="ltr"><<a href="mailto:mposolda@redhat.com" target="_blank">mposolda@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On 27/10/15 14:05, Bill Burke wrote:<br>
> IMO, most applications will not care about account duplication. Most<br>
> users won't care about account linking. So, IMO:<br>
</span>Remember you mentioned that already in the previous discussions. IMO<br>
people care and usually want to have single account on single site. If<br>
you have 2 accounts, you never know to which of your accounts you are<br>
authenticated. This causes various issues, like permissions available to<br>
account1, but you are logged with account2 etc.<br>
<br>
Remember some time ago I messed on some site and have 2 accounts like<br>
"mposolda" and "<a href="mailto:mposolda@redhat.com">mposolda@redhat.com</a>" . I had always issues like that<br>
when I was logged as "mposolda" I had "Access denied" when going to page<br>
I was supposed to have permission. So needed to logout and login again<br>
as "<a href="mailto:mposolda@redhat.com">mposolda@redhat.com</a>" etc.<br>
<span class="">><br>
> 1) users should not be required to link accounts. In the case where an<br>
> account cannot be automatically linked a duplicate account should be<br>
> created<br>
> 2) Providers should be trusted by default. Trusted providers can just<br>
> automatically link themselves to existing accounts that were logged in<br>
> by other trusted providers.<br>
> 3) Untrusted providers can automatically link if email has been verified<br>
> for all parties.<br>
> 4) Users can merge accounts that have verified emails.<br>
> 5) An alternative to user self merging of account could be requiring to<br>
> enter in a temporary code after logging into each account.<br>
><br>
><br>
> #1 and #2 can be added with minimal changes to code. #3 requires a flow<br>
> on broker login and a rework of the broker SPI. #4 is account service<br>
> changes. #5 might be as easy as adding a required action.<br>
><br>
> I guess it depends if ultimate flexibility is needed. #1, #2 and #4<br>
> might be enough and require the least amount of changes and SPI refactoring.<br>
</span>I think that flexibility is needed based on various JIRAs and feedback.<br>
Just talked with Vlasta Elias from <a href="http://jboss.org" rel="noreferrer" target="_blank">jboss.org</a>. They have even more<br>
requirements for possible conditions when accounts should be merged and<br>
how to merge accounts. For example Vlasta mentioned the usecase like:<br>
- When user logges with Facebook (or other provider) account, which is<br>
not yet linked to any Keycloak account, then new account on Keycloak<br>
side shouldn't be created automatically. Even if I logged with Facebook<br>
<a href="mailto:bob@gmail.com">bob@gmail.com</a> and there is no KC account for email <a href="mailto:bob@gmail.com">bob@gmail.com</a>, there<br>
is requirement to always show the screen like: "You just logged with<br>
facebook account <a href="mailto:bob@gmail.com">bob@gmail.com</a>. Do you want to link it with existing<br>
keycloak account?" If user agree, he would need to provide Keycloak<br>
account he wants to merge and then verify email or re-authenticate to<br>
link Facebook with existing account<br>
<br>
- Another use-case was to merge account automatically based on username<br>
from thirdparty SAML provider. For example the SAMLResponse with<br>
username "john" returned from SAML provider, there is a need to<br>
automatically merge it with Keycloak account "john" . In this case, they<br>
know that "john" will be always available on Keycloak side because of<br>
Federation provider, which SAML IDP uses as storage as well.<br>
<br>
Based on all of this, it looks that introducing Auth SPI for first time<br>
broker login is a way to go. This will address all of #1, #2 and #3 and<br>
many other usecases.<br>
<br>
For your #2, I agree that providers should be trusted by default. But<br>
not all of providers, because some of them don't verify email. AFAIK<br>
Facebook and Google verify email. But Github doesn't . It will be a<br>
security hole to trust github provider by default because then user can<br>
do something like:<br>
- He can create github account with any email he wants like<br>
"<a href="mailto:mposolda@redhat.com">mposolda@redhat.com</a>"<br>
- Login with this github account into Keycloak. If we trust the email by<br>
default, he will be logged into Keycloak to account<br>
"<a href="mailto:mposolda@redhat.com">mposolda@redhat.com</a>", which is not his email -> FAIL<br>
<br>
I am not sure about support for merging accounts in Account management<br>
(like #4 and #5), will try to work on login flow first and will try to<br>
possibly look at account management then.<br>
<span class="HOEnZb"><font color="#888888"><br>
Marek<br>
</font></span><div class="HOEnZb"><div class="h5">><br>
><br>
> On 10/27/2015 4:33 AM, Marek Posolda wrote:<br>
>> I went again through all the previous discussions, related JIRAs and<br>
>> requirements. As of now, my plan is to:<br>
>><br>
>> - Use authentication SPI to handle the flow and related actions for<br>
>> first social login. (Update user profile, Detect duplicated account,<br>
>> Verify email or reauthenticate user if duplication is detected, Create<br>
>> social link to existing account). This allows most flexibility for<br>
>> admins to specify how exactly the linking should work<br>
>><br>
>> - Detecting duplication will be based on email only by default - (For<br>
>> example duplication is detected if Facebook user with email<br>
>> <a href="mailto:bob@gmail.com">bob@gmail.com</a> authenticates, but there is already Keycloak user with<br>
>> email <a href="mailto:bob@gmail.com">bob@gmail.com</a> ). The people can provide their own execution if<br>
>> they want different way for detect duplications<br>
>><br>
>> - It seems it's more proper to postpone creating user account later,<br>
>> once we know that there is no duplication. In other words, if "Update<br>
>> profile on first login" is enabled, the user account is not yet created<br>
>> when the update profile page is shown. All the info related to<br>
>> BrokeredIdentityContext stuff will be available on ClientSession. This<br>
>> seems to me easier and more proper solution then creating temporary<br>
>> account with email in some "temporary" attribute. Temporary accounts<br>
>> have other challenges (Cleaner thread for delete outdated unmerged<br>
>> accounts etc).<br>
>><br>
>> - If "trustEmail" flag is on for IdentityProvider, the provider link<br>
>> will be created automatically. (For example if Facebook user<br>
>> <a href="mailto:bob@gmail.com">bob@gmail.com</a> authenticates for the first time and there is already<br>
>> Keycloak user with email <a href="mailto:bob@gmail.com">bob@gmail.com</a> and trustEmail is on, the<br>
>> Facebook link is automatically created for Keycloak account<br>
>> <a href="mailto:bob@gmail.com">bob@gmail.com</a> without any additional verification)<br>
>><br>
>> - If "trustEmail" flag is off, there would need to be other way to<br>
>> verify user before creating social link. The user will first confirm if<br>
>> he wants to merge the accounts. Then there will be either:<br>
>> -- Email verification: The mail will be sent to <a href="mailto:bob@gmail.com">bob@gmail.com</a> like<br>
>> "Someone authenticates to Keycloak server <a href="http://www.keycloak.org:8080" rel="noreferrer" target="_blank">http://www.keycloak.org:8080</a><br>
>> through Facebook account <a href="mailto:bob@gmail.com">bob@gmail.com</a> and wants to link Facebook<br>
>> account with existing Keycloak account <a href="mailto:bob@gmail.com">bob@gmail.com</a> . If it is you,<br>
>> click here" . After user clicks, the social link is created<br>
>> -- Further authentication: User will need to authenticate to existing<br>
>> <a href="mailto:bob@gmail.com">bob@gmail.com</a> keycloak account through password (or OTP or both or<br>
>> something else)<br>
>> All of this is configurable through flows, so admin can disable the "Do<br>
>> you want to create social link?" screen, or enforce email verification<br>
>> instead of authentication, configure required authenticators etc.<br>
>><br>
>> - I am not sure if we want to handle just merge with existing account<br>
>> during first broker login, or if we also want to handle merging of<br>
>> accounts in account management? For now, I am planning to handle just<br>
>> the login flow and possibly address Account management later if there is<br>
>> need for it. The merging accounts in account management might be quite a<br>
>> challenge as there is merge of 2 already existing user accounts with<br>
>> various issues related to it (Which roles/permissions should merged<br>
>> account have? Which attributes it should have? Which federation link?<br>
>> etc.). But at least, I am planning to address the issue with redirect to<br>
>> login forms error screen instead of stay in account management -<br>
>> <a href="https://issues.jboss.org/browse/KEYCLOAK-1822" rel="noreferrer" target="_blank">https://issues.jboss.org/browse/KEYCLOAK-1822</a><br>
>><br>
>> Marek<br>
>> _______________________________________________<br>
>> keycloak-dev mailing list<br>
>> <a href="mailto:keycloak-dev@lists.jboss.org">keycloak-dev@lists.jboss.org</a><br>
>> <a href="https://lists.jboss.org/mailman/listinfo/keycloak-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailman/listinfo/keycloak-dev</a><br>
>><br>
<br>
_______________________________________________<br>
keycloak-dev mailing list<br>
<a href="mailto:keycloak-dev@lists.jboss.org">keycloak-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/keycloak-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailman/listinfo/keycloak-dev</a><br>
</div></div></blockquote></div><br></div>