<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On 12 January 2016 at 16:26, Bill Burke <span dir="ltr"><<a href="mailto:bburke@redhat.com" target="_blank">bburke@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000"><span class="">
<br>
<br>
<div>On 1/12/2016 2:45 AM, Stian Thorgersen
wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr"><br>
<div class="gmail_extra"><br>
<div class="gmail_quote">On 12 January 2016 at 03:22, Bill
Burke <span dir="ltr"><<a href="mailto:bburke@redhat.com" target="_blank">bburke@redhat.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">I
can't find the original email on this, but we need to do
this for<br>
1.9. I can start doing it one module at a time: </blockquote>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><br>
Common:<br>
keycloak-common<br>
keycloak-common-saml<br>
keycloak-common-oidc<br>
<br>
Libraries server:<br>
<br>
keycloak-server-spi - all SPI interfaces and common code<br>
keycloak-server-saml - all saml server code, broker and
protocol plugins<br>
keycloak-server-oidc - all oidc code, broker and protocol
plugins<br>
keycloak-server-impl - everything<br>
</blockquote>
<div><br>
</div>
<div>I'm not 100% sure we should put all implementations of
SPIs into keycloak-server-impl. We at least need to keep
Mongo separate as it's not part of the product.</div>
<div><br>
</div>
<div>If we put all SPI implementations, including services,
into the same module we'd end up with one huge module.
There's also a risk that we'd end up with strong
relationships between them, rather than having them
properly linked via SPI interfaces.</div>
<div><br>
</div>
<div>I'm a bit 50/50 on it though.</div>
</div>
</div>
</div>
</blockquote></span>
You do remember how many modules we currently have don't you?
Minimally, we should have a big SPI module right? <br></div></blockquote><div><br></div><div>I'm absolutely on board with:</div><div><br></div><div>Common:</div><div>keycloak-common</div><div>keycloak-common-saml</div><div>keycloak-common-oidc</div><div><br></div><div>Libraries server:</div><div>keycloak-server-spi<br></div><div><br></div><div>So we can agree on that, I'm just not 100% sure about a single module for all SPI implementations and services.</div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div bgcolor="#FFFFFF" text="#000000"><span class="">
<br>
<br>
<pre cols="72">--
Bill Burke
JBoss, a division of Red Hat
<a href="http://bill.burkecentral.com" target="_blank">http://bill.burkecentral.com</a></pre>
</span></div>
</blockquote></div><br></div></div>