<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
You've done some good work Thomas. Thanks for your contributions!<br>
<br>
<div class="moz-cite-prefix">On 1/15/2016 7:47 AM, Thomas Darimont
wrote:<br>
</div>
<blockquote
cite="mid:CAK-7U1jJU4GV6JgGKOTGHWVAhs9L=CzNW65jKdaawewBLEpBYg@mail.gmail.com"
type="cite">
<div dir="ltr">Ok, I can give it a spin this evening
<div><br>
</div>
<div>Cheers,</div>
<div>Thomas</div>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">2016-01-15 10:47 GMT+01:00 Stian
Thorgersen <span dir="ltr"><<a moz-do-not-send="true"
href="mailto:sthorger@redhat.com" target="_blank">sthorger@redhat.com</a>></span>:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">For the record we can't prioritize it at the
moment</div>
<div class="HOEnZb">
<div class="h5">
<div class="gmail_extra"><br>
<div class="gmail_quote">On 15 January 2016 at 10:06,
Thomas Darimont <span dir="ltr"><<a
moz-do-not-send="true"
href="mailto:thomas.darimont@googlemail.com"
target="_blank"><a class="moz-txt-link-abbreviated" href="mailto:thomas.darimont@googlemail.com">thomas.darimont@googlemail.com</a></a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">Okay, I filed: <a
moz-do-not-send="true"
href="https://issues.jboss.org/browse/KEYCLOAK-2324"
target="_blank"><a class="moz-txt-link-freetext" href="https://issues.jboss.org/browse/KEYCLOAK-2324">https://issues.jboss.org/browse/KEYCLOAK-2324</a></a>
<div><br>
</div>
<div>Cheers,</div>
<div>Thomas</div>
</div>
<div>
<div>
<div class="gmail_extra"><br>
<div class="gmail_quote">2016-01-15 9:55
GMT+01:00 Stian Thorgersen <span
dir="ltr"><<a moz-do-not-send="true"
href="mailto:sthorger@redhat.com"
target="_blank">sthorger@redhat.com</a>></span>:<br>
<blockquote class="gmail_quote"
style="margin:0 0 0 .8ex;border-left:1px
#ccc solid;padding-left:1ex">
<div dir="ltr">Sounds good to me. The
AdminEventBuilder.resourcePath could
set it so we don't have to have the
logic spread around.</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">
<div>
<div>On 15 January 2016 at 09:45,
Thomas Darimont <span dir="ltr"><<a
moz-do-not-send="true"
href="mailto:thomas.darimont@googlemail.com"
target="_blank"><a class="moz-txt-link-abbreviated" href="mailto:thomas.darimont@googlemail.com">thomas.darimont@googlemail.com</a></a>></span>
wrote:<br>
</div>
</div>
<blockquote class="gmail_quote"
style="margin:0 0 0
.8ex;border-left:1px #ccc
solid;padding-left:1ex">
<div>
<div>
<div dir="ltr">
<div>Hi,</div>
<div><br>
</div>
<div>currently it is hard to
figure out what actually
happend when processing
events, since there</div>
<div>is no explicit
information about the
actual underlying resource
in an event. Currently one
has to </div>
<div>parse the resourcePath
of an AdminEvent to deduce
the involved resource.</div>
<div><br>
</div>
<div>E.g. Creating a user
yields:</div>
<div><br>
</div>
<div>AdminEvent#getOperationType():
CREATE</div>
<div>AdminEvent#getResourcePath():
users/edbabe12-528a-42cc-90cc-bbc66ebaa472</div>
<div><br>
</div>
<div>Assigning a client role
to a user yields:</div>
<div><br>
</div>
<div>AdminEvent#getOperationType():
CREATE</div>
<div>AdminEvent#getResourcePath():
users/edbabe12-528a-42cc-90cc-bbc66ebaa472/role-mappings/clients/7f3af5dc-b68b-4bda-b5a3-89b6d827fb1e</div>
<div><br>
</div>
<div>Removing a client role
from a user yields:</div>
<div>AdminEvent#getOperationType():
DELETE</div>
<div>AdminEvent#getResourcePath():
users/edbabe12-528a-42cc-90cc-bbc66ebaa472/role-mappings/clients/7f3af5dc-b68b-4bda-b5a3-89b6d827fb1e</div>
<div><br>
</div>
<div>It would be helpful if
one had more information
about the actual use case.</div>
<div><br>
</div>
<div>How about introducing
an
AdminEvent#getResourceType()
method that returns an
enum value for the </div>
<div>resource in question,
e.g. USER, ROLE, CLIENT,
REALM, GROUP,
ROLE_ASSIGNMENT,
CLIENT_ROLE_ASSIGNMENT,
GROUP_ASSIGNMENT, etc.</div>
<div><br>
</div>
<div>This would make it
easier detect what
actually happend without
having to parse the
resourcePath.</div>
<div><br>
</div>
<div>What do you think?</div>
<div><br>
</div>
<div>Cheers,</div>
<div>Thomas</div>
<div><br>
</div>
</div>
<br>
</div>
</div>
_______________________________________________<br>
keycloak-dev mailing list<br>
<a moz-do-not-send="true"
href="mailto:keycloak-dev@lists.jboss.org"
target="_blank">keycloak-dev@lists.jboss.org</a><br>
<a moz-do-not-send="true"
href="https://lists.jboss.org/mailman/listinfo/keycloak-dev"
rel="noreferrer" target="_blank">https://lists.jboss.org/mailman/listinfo/keycloak-dev</a><br>
</blockquote>
</div>
<br>
</div>
</blockquote>
</div>
<br>
</div>
</div>
</div>
</blockquote>
</div>
<br>
</div>
</div>
</div>
</blockquote>
</div>
<br>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
keycloak-dev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:keycloak-dev@lists.jboss.org">keycloak-dev@lists.jboss.org</a>
<a class="moz-txt-link-freetext" href="https://lists.jboss.org/mailman/listinfo/keycloak-dev">https://lists.jboss.org/mailman/listinfo/keycloak-dev</a></pre>
</blockquote>
<br>
<pre class="moz-signature" cols="72">--
Bill Burke
JBoss, a division of Red Hat
<a class="moz-txt-link-freetext" href="http://bill.burkecentral.com">http://bill.burkecentral.com</a></pre>
</body>
</html>