<div dir="ltr">To 1.8.x as well</div><div class="gmail_extra"><br><div class="gmail_quote">On 20 January 2016 at 10:25, Stian Thorgersen <span dir="ltr"><<a href="mailto:sthorger@redhat.com" target="_blank">sthorger@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Added identity provider and external username to login event when login via broker</div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">On 20 January 2016 at 09:31, Libor Krzyzanek <span dir="ltr"><<a href="mailto:lkrzyzan@redhat.com" target="_blank">lkrzyzan@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">I’m fine with “LOGIN” event for any type of login (form/social etc.) and distinguish the used method in event’s details.<br>
<br>
The issue right now is that provider id is not included in login event.<br>
Do you think you can fix that in 1.8.0.CR2? Is it bigger change or just small thing to add?<br>
<br>
Thanks,<br>
<br>
Libor Krzyžanek<br>
<a href="http://jboss.org" rel="noreferrer" target="_blank">jboss.org</a> Development Team<br>
<div><div><br>
> On Jan 19, 2016, at 1:33 PM, Stian Thorgersen <<a href="mailto:sthorger@redhat.com" target="_blank">sthorger@redhat.com</a>> wrote:<br>
><br>
> It seems like there's a bit of confusion with regards to what events should be fired when a identity broker login occurs.<br>
><br>
> Initially it was LOGIN and auth_method was used to differentiate how the user authenticated.<br>
><br>
> Then it was changed to IDENTITY_PROVIDER_LOGIN.<br>
><br>
> Now it seems to be back to LOGIN.<br>
><br>
> This is rather messy! Why has it been changed so much?<br>
><br>
> IMO it should as it was initially (LOGIN with auth_method). We also need to make sure identity provider id and sub is included. The latter is missing at the moment.<br>
</div></div>> _______________________________________________<br>
> keycloak-dev mailing list<br>
> <a href="mailto:keycloak-dev@lists.jboss.org" target="_blank">keycloak-dev@lists.jboss.org</a><br>
> <a href="https://lists.jboss.org/mailman/listinfo/keycloak-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailman/listinfo/keycloak-dev</a><br>
<br>
</blockquote></div><br></div>
</div></div></blockquote></div><br></div>