<div dir="ltr">When/how do you hit the code that is binary incompatible though?</div><div class="gmail_extra"><br><div class="gmail_quote">On 21 January 2016 at 16:20, Christian Beikov <span dir="ltr"><<a href="mailto:christian.beikov@gmail.com" target="_blank">christian.beikov@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000">
Because you probably didn't hit the code that is binary
incompatible. As you can see in the stacktrace, the
ungetRequestBytes method has a different signature in Undertow 1.3.x<div><div class="h5"><br>
<br>
<div>Am 21.01.2016 um 16:19 schrieb Stian
Thorgersen:<br>
</div>
<blockquote type="cite">
<div dir="ltr">It depends on what the actual problem is though,
because we have tested it on WF10 and we didn't discover any
issues</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On 21 January 2016 at 16:18, Stian
Thorgersen <span dir="ltr"><<a href="mailto:sthorger@redhat.com" target="_blank">sthorger@redhat.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">If the adapter is broken for WF10, we need to
fix for 1.8 as well</div>
<div>
<div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On 21 January 2016 at 16:15,
Bill Burke <span dir="ltr"><<a href="mailto:bburke@redhat.com" target="_blank"></a><a href="mailto:bburke@redhat.com" target="_blank">bburke@redhat.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000"> Log a jira
and schedule for 1.9. I'll either create a new
adapter or find a workaround that is backward
compatible. <br>
<div>
<div> <br>
<div>On 1/21/2016 10:09 AM, Stian Thorgersen
wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr">What is your problem when
you are actually using the adapter?
<div><br>
</div>
<div>As I said we need the adapter to
compile against multiple versions, we
can not maintain one per version of
WildFly.</div>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On 21 January
2016 at 16:07, Christian Beikov <span dir="ltr"><<a href="mailto:christian.beikov@gmail.com" target="_blank"></a><a href="mailto:christian.beikov@gmail.com" target="_blank">christian.beikov@gmail.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000"> As I wrote, when
you change the Undertow version in
the parent pom, a build will
generate a compilation error when
using the Undertow version that is
used in Wildfly 10 which would be
1.3.x.<br>
<br>
I encountered the following
exception in the Undertow adapters
because of binary
incompatibilities between Undertow
1.2.x and 1.3.x:<br>
<br>
java.lang.NoSuchMethodError:
io.undertow.server.Connectors.ungetRequestBytes(Lio/undertow/server/HttpServerExchange;[Lorg/xnio/Pooled;)V<br>
at
org.keycloak.adapters.undertow.SavedRequest.tryRestoreRequest(SavedRequest.java:112)<br>
at
org.keycloak.adapters.undertow.ServletSessionTokenStore.restoreRequest(ServletSessionTokenStore.java:119)<br>
at
org.keycloak.adapters.undertow.ServletSessionTokenStore.isCached(ServletSessionTokenStore.java:67)<br>
at
org.keycloak.adapters.RequestAuthenticator.authenticate(RequestAuthenticator.java:88)<br>
at
org.keycloak.adapters.undertow.AbstractUndertowKeycloakAuthMech.keycloakAuthenticate(AbstractUndertowKeycloakAuthMech.java:110)<br>
at
org.keycloak.adapters.undertow.ServletKeycloakAuthMech.authenticate(ServletKeycloakAuthMech.java:92)<br>
<br>
<br>
Regards,<br>
Christian
<div>
<div><br>
<br>
<div>Am 21.01.2016 um 16:00
schrieb Stian Thorgersen:<br>
</div>
<blockquote type="cite">
<div dir="ltr">When we
tested it, it worked. So I
need more details from you
to reproduce this.</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On
21 January 2016 at
14:50, Christian Beikov
<span dir="ltr"><<a href="mailto:christian.beikov@gmail.com" target="_blank"></a><a href="mailto:christian.beikov@gmail.com" target="_blank">christian.beikov@gmail.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000"> I
deploy the adapter
by
overlaying/copying
the adapter modules
into my Wildfly.<br>
<br>
I understand that
you support older
Wildfly versions
too, but I guess you
have to create a
separate adapter for
Wildfly 10 then.<br>
You can easily see
that there are
incompatibilities
between Undertow
1.2.x and 1.3.x
which will result in
a failed compilation
if you change the
Undertow version in
the parent pom for
testing purposes.<br>
<br>
Regards,<br>
Christian
<div>
<div><br>
<br>
<div>Am
21.01.2016 um
14:44 schrieb
Stian
Thorgersen:<br>
</div>
<blockquote type="cite">
<div dir="ltr">BTW
we support
older versions
of WildFly as
well as 10, so
it's not as
simple as
upgrading the
undertow
version</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On
21 January
2016 at 14:43,
Stian
Thorgersen <span dir="ltr"><<a href="mailto:sthorger@redhat.com" target="_blank"></a><a href="mailto:sthorger@redhat.com" target="_blank">sthorger@redhat.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">How
are you
deploying the
adapter and
what adapter
are you using?
We have tested
the adapter
with WildFly
10 (Keycloak
1.8.0.CR1 was
tested on
10.0.0.CR5)
and it worked
fine.</div>
<div>
<div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On
21 January
2016 at 14:30,
Christian
Beikov <span dir="ltr"><<a href="mailto:christian.beikov@gmail.com" target="_blank"></a><a href="mailto:christian.beikov@gmail.com" target="_blank">christian.beikov@gmail.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hello,<br>
<br>
I am trying to
deploy
Keycloak
1.8.0.CR1 to
Wildfly
10.0.0.CR4 but
there<br>
are some
problems with
that.<br>
You are
compiling
against
Undertow
1.1.1.Final
but Wildfly
10.0.0.CR4<br>
comes with
1.3.3.Final
and there are
some binary
incompatibilities
in<br>
io.undertow.server.Connectors
of which<br>
org.keycloak.adapters.undertow.SavedRequest
is affected.<br>
You are using
io.undertow.util.ImmediatePooled
instead of the
expected<br>
type
io.undertow.connector.PooledByteBuffer
which leads to
method not<br>
found
exceptions.<br>
I suggest you
update the
undertow
version in the
parent pom.xml
to make<br>
sure
everything is
binary
compatible if
you are going
to support
Wildfly<br>
10 as you
announced.<br>
<br>
Regards,<br>
Christian<br>
_______________________________________________<br>
keycloak-dev
mailing list<br>
<a href="mailto:keycloak-dev@lists.jboss.org" target="_blank"></a><a href="mailto:keycloak-dev@lists.jboss.org" target="_blank">keycloak-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/keycloak-dev" target="_blank"></a><a href="https://lists.jboss.org/mailman/listinfo/keycloak-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/keycloak-dev</a><br>
</blockquote>
</div>
<br>
</div>
</div>
</div>
</blockquote>
</div>
<br>
</div>
</blockquote>
<br>
</div>
</div>
</div>
</blockquote>
</div>
<br>
</div>
</blockquote>
<br>
</div>
</div>
</div>
</blockquote>
</div>
<br>
</div>
<br>
<fieldset></fieldset>
<br>
<pre>_______________________________________________
keycloak-dev mailing list
<a href="mailto:keycloak-dev@lists.jboss.org" target="_blank">keycloak-dev@lists.jboss.org</a>
<a href="https://lists.jboss.org/mailman/listinfo/keycloak-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/keycloak-dev</a></pre>
</blockquote>
<br>
</div>
</div>
<span><font color="#888888">
<pre cols="72">--
Bill Burke
JBoss, a division of Red Hat
<a href="http://bill.burkecentral.com" target="_blank">http://bill.burkecentral.com</a></pre>
</font></span></div>
<br>
_______________________________________________<br>
keycloak-dev mailing list<br>
<a href="mailto:keycloak-dev@lists.jboss.org" target="_blank">keycloak-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/keycloak-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailman/listinfo/keycloak-dev</a><br>
</blockquote>
</div>
<br>
</div>
</div>
</div>
</blockquote>
</div>
<br>
</div>
<br>
<fieldset></fieldset>
<br>
<pre>_______________________________________________
keycloak-dev mailing list
<a href="mailto:keycloak-dev@lists.jboss.org" target="_blank">keycloak-dev@lists.jboss.org</a>
<a href="https://lists.jboss.org/mailman/listinfo/keycloak-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/keycloak-dev</a></pre>
</blockquote>
<br>
</div></div></div>
<br>_______________________________________________<br>
keycloak-dev mailing list<br>
<a href="mailto:keycloak-dev@lists.jboss.org">keycloak-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/keycloak-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailman/listinfo/keycloak-dev</a><br></blockquote></div><br></div>