<div dir="ltr">Got a tip about <a href="http://editorconfig.org/">http://editorconfig.org/</a>. Looks interesting, anyone tried it?</div><div class="gmail_extra"><br><div class="gmail_quote">On 25 January 2016 at 12:02, Stian Thorgersen <span dir="ltr"><<a href="mailto:sthorger@redhat.com" target="_blank">sthorger@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">I'll take a look at it, but sounds like exactly what we'll need. We can just copy those to Keycloak, then do a batch format of the code. In the future we can consider if a checkstyle is required.</div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">On 25 January 2016 at 11:33, Marek Posolda <span dir="ltr"><<a href="mailto:mposolda@redhat.com" target="_blank">mposolda@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000"><span>
<div>On 21/01/16 20:28, Stian Thorgersen
wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr">I'm wasn't planing on having a lengthy discussion
about code style. It's usually just a matter of personal
preference and folks do get used to most things.
<div><br>
</div>
<div>Questions are:</div>
<div><br>
</div>
<div>* Should we have a code style?</div>
<div>* What IDEs are Keycloak devs using (I'm crossing my
fingers everyone says IntelliJ)</div>
<div>* Should we enable the checkstyle plugin?</div>
<div><br>
</div>
<div>With regards to the actual style my first thought was to
base it on WildFly code style (we do build on top of it after
all). However, they do not have one for IntelliJ, which makes
it a no go IMO. Further I don't particularly want to craft one
(and try to get configs for IntelliJ match Eclipse, which also
passes the checkstyle). So do anyone have suggestions of other
projects we can borrow from?</div>
</div>
</blockquote></span>
I am using the Intellij and have the codestyle file imported from
liveoak. Among other things, it has "import package.*" prevented
(related discussion in other thread). <br>
<br>
We had netbeans, eclipse and intellij there and I hope there were in
sync:
<a href="https://github.com/liveoak-io/liveoak/tree/master/support/ide-configs" target="_blank">https://github.com/liveoak-io/liveoak/tree/master/support/ide-configs</a>
. <br>
<br>
Seeing there was also checkstyle as well:
<a href="https://github.com/liveoak-io/liveoak/blob/master/support/build-config/src/main/resources/liveoak-checkstyle/checkstyle.xml" target="_blank">https://github.com/liveoak-io/liveoak/blob/master/support/build-config/src/main/resources/liveoak-checkstyle/checkstyle.xml</a><span><font color="#888888"><br>
<br>
Marek<br>
</font></span><blockquote type="cite"><span>
<div dir="ltr">
<div><br>
</div>
<div>If we're going to incorporate a code style and re-format
the current code case now is a very good time.</div>
</div>
<br>
<fieldset></fieldset>
<br>
</span><span><pre>_______________________________________________
keycloak-dev mailing list
<a href="mailto:keycloak-dev@lists.jboss.org" target="_blank">keycloak-dev@lists.jboss.org</a>
<a href="https://lists.jboss.org/mailman/listinfo/keycloak-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/keycloak-dev</a></pre>
</span></blockquote>
<br>
</div>
</blockquote></div><br></div>
</div></div></blockquote></div><br></div>