<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">We agreed on this in some other thread:
<a class="moz-txt-link-freetext" href="http://lists.jboss.org/pipermail/keycloak-dev/2016-January/006243.html">http://lists.jboss.org/pipermail/keycloak-dev/2016-January/006243.html</a><br>
<br>
By default, firstBrokerLogin flow addresses conflicts in both
email and username. So conflict in username can now be easily
resolved and accounts can be linked at login time. So there is not
much need to use tricky usernames like "brokerID.brokerUsername"
anymore.<br>
<br>
This PR addresses just default behaviour. If username mapper is
used, it has always precedence. So there is still possibility to
go back to previous behaviour or configure username template
however you want.<br>
<br>
Marek<br>
<br>
On 29/01/16 19:49, Bill Burke wrote:<br>
</div>
<blockquote cite="mid:56ABB423.9070509@redhat.com" type="cite">
<meta http-equiv="content-type" content="text/html;
charset=windows-1252">
Can I ask why we did this? There will be name clashes. User has
the power to change the name mapping already, don't they?<br>
<div class="moz-forward-container"><br>
<br>
-------- Forwarded Message --------
<table class="moz-email-headers-table" border="0"
cellpadding="0" cellspacing="0">
<tbody>
<tr>
<th align="RIGHT" nowrap="nowrap" valign="BASELINE">Subject:
</th>
<td>[keycloak] KEYCLOAK-2292 Broker login: remove identity
provider prefix from auto… (#2141)</td>
</tr>
<tr>
<th align="RIGHT" nowrap="nowrap" valign="BASELINE">Date:
</th>
<td>Fri, 29 Jan 2016 09:43:47 -0800</td>
</tr>
<tr>
<th align="RIGHT" nowrap="nowrap" valign="BASELINE">From:
</th>
<td>Marek Posolda <a moz-do-not-send="true"
class="moz-txt-link-rfc2396E"
href="mailto:notifications@github.com"><notifications@github.com></a></td>
</tr>
<tr>
<th align="RIGHT" nowrap="nowrap" valign="BASELINE">Reply-To:
</th>
<td>keycloak/keycloak
<a moz-do-not-send="true" class="moz-txt-link-rfc2396E"
href="mailto:reply+000abeef51cc88b4da9732edfddbd34fa49c6a261b2d314092cf0000000112c366d392a169ce07bd2342@reply.github.com"><reply+000abeef51cc88b4da9732edfddbd34fa49c6a261b2d314092cf0000000112c366d392a169ce07bd2342@reply.github.com></a></td>
</tr>
<tr>
<th align="RIGHT" nowrap="nowrap" valign="BASELINE">To: </th>
<td>keycloak/keycloak <a moz-do-not-send="true"
class="moz-txt-link-rfc2396E"
href="mailto:keycloak@noreply.github.com"><keycloak@noreply.github.com></a></td>
</tr>
</tbody>
</table>
<br>
<br>
<p>…generated username</p>
<hr>
<h4>You can view, comment on, or merge this pull request online
at:</h4>
<p> <a moz-do-not-send="true"
href="https://github.com/keycloak/keycloak/pull/2141">https://github.com/keycloak/keycloak/pull/2141</a></p>
<h4>Commit Summary</h4>
<ul>
<li>KEYCLOAK-2292 Broker login: remove identity provider
prefix from autogenerated username</li>
</ul>
<h4>File Changes</h4>
<ul>
<li> <strong>M</strong> <a moz-do-not-send="true"
href="https://github.com/keycloak/keycloak/pull/2141/files#diff-0">services/src/main/java/org/keycloak/services/resources/IdentityBrokerService.java</a>
(2) </li>
<li> <strong>M</strong> <a moz-do-not-send="true"
href="https://github.com/keycloak/keycloak/pull/2141/files#diff-1">testsuite/integration/src/test/java/org/keycloak/testsuite/broker/AbstractIdentityProviderTest.java</a>
(2) </li>
<li> <strong>M</strong> <a moz-do-not-send="true"
href="https://github.com/keycloak/keycloak/pull/2141/files#diff-2">testsuite/integration/src/test/java/org/keycloak/testsuite/broker/AbstractKeycloakIdentityProviderTest.java</a>
(4) </li>
<li> <strong>M</strong> <a moz-do-not-send="true"
href="https://github.com/keycloak/keycloak/pull/2141/files#diff-3">testsuite/integration/src/test/java/org/keycloak/testsuite/broker/PostBrokerFlowTest.java</a>
(10) </li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a moz-do-not-send="true"
href="https://github.com/keycloak/keycloak/pull/2141.patch">https://github.com/keycloak/keycloak/pull/2141.patch</a></li>
<li><a moz-do-not-send="true"
href="https://github.com/keycloak/keycloak/pull/2141.diff">https://github.com/keycloak/keycloak/pull/2141.diff</a></li>
</ul>
<p
style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br>
Reply to this email directly or <a moz-do-not-send="true"
href="https://github.com/keycloak/keycloak/pull/2141">view
it on GitHub</a>.<img moz-do-not-send="true" alt=""
src="https://github.com/notifications/beacon/AAq-7zSdYYqWl0HtFPb8cLSpc2YUSmKYks5pe5xTgaJpZM4HPZ7d.gif"
height="1" width="1"></p>
<div itemscope="" itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope=""
itemtype="http://schema.org/ViewAction">
<link itemprop="url"
href="https://github.com/keycloak/keycloak/pull/2141">
<meta itemprop="name" content="View Pull Request">
</div>
<meta itemprop="description" content="View this Pull Request
on GitHub">
</div>
<br>
<pre class="moz-signature" cols="72">--
Bill Burke
JBoss, a division of Red Hat
<a moz-do-not-send="true" class="moz-txt-link-freetext" href="http://bill.burkecentral.com">http://bill.burkecentral.com</a></pre>
<br>
</div>
<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
keycloak-dev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:keycloak-dev@lists.jboss.org">keycloak-dev@lists.jboss.org</a>
<a class="moz-txt-link-freetext" href="https://lists.jboss.org/mailman/listinfo/keycloak-dev">https://lists.jboss.org/mailman/listinfo/keycloak-dev</a></pre>
</blockquote>
<br>
</body>
</html>