<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On 12 April 2016 at 15:24, Luke Holmquist <span dir="ltr"><<a href="mailto:lholmqui@redhat.com" target="_blank">lholmqui@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><span class="">On Tue, Apr 12, 2016 at 12:29 AM, Stian Thorgersen <span dir="ltr"><<a href="mailto:sthorger@redhat.com" target="_blank">sthorger@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr">Having the same version makes it much easier for people to grab a version they know works with a specific Keycloak version. It also makes it simpler when we release.<div><br></div><div>Keycloak has a 6 week release cadence </div></div></blockquote></span><div>While this probably works most of the time, i'm wondering what happens, for example, if in the node.js adapter there is a security vulnerability in one of the dependent packages that is discovered a couple days after a release, would you then need to create a new release of all of Keycloak? that is fine, i'm just wondering if thats what would happen since that could be a real possibility. so for an issue like this: <span style="font-size:13px"> </span><a href="https://issues.jboss.org/browse/KEYCLOAK-2798" style="font-size:13px" target="_blank">https://issues.jboss.org/browse/KEYCLOAK-2798</a><span style="font-size:13px">. a full keycloak release would need to </span>happen then?</div></div></div></div></blockquote><div><br></div><div>It depends on the severity of the vulnerability. If it's critical a minor release will be done (of everything) asap. Bugs and improvements will not be pushed out more frequently than 6 weeks.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div><br></div><div>*everything i said above only applies if that node adapter is a full class citizen, obviously "community" things are different *</div></div></div></div></blockquote><div><br></div><div>The aim is to make the nodejs adapter a full class citizen soon :)</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div><div class="h5"><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><div>and adapters shouldn't be released more frequently. Rather they should be released at the same time as the server and by the same release job in Jenkins.</div><div><br></div><div>To become a first class citizen an adapter has to:</div><div><br></div><div>* Release at same time as Keycloak server (every ~6 weeks). We test and release everything as a bundle and don't have the resources to maintain separate release cycles. I also want all adapters to be consistent here.</div><div>* Documentation - we're going to have a adapters documentation, it will have a separate chapter for each adapter. Each adapter chapter will have a getting started and a reference/developer guide. There's also need for the relevant api docs in whatever format is most popular for a specific language</div><div>* Examples - not sure where these will live. Maybe all examples for all adapters are in one repo</div><div><br></div><div>Any changes to the above has to be raised. If you really want to discuss that then send a generic message to keycloak-dev list, basically don't include NodeJS in the title ;).</div></div><div><div><div class="gmail_extra"><br><div class="gmail_quote">On 11 April 2016 at 20:27, Lance Ball <span dir="ltr"><<a href="mailto:lball@redhat.com" target="_blank">lball@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr">I agree that keeping version numbers consistent might be questionable. There is the big bump as Bruno notes, but also the npm modules need to be able to publish in the absence of a keycloak release in the event that there are bugs which need to be addressed in an adapter but not in keycloak itself - e.g. <a href="https://issues.jboss.org/browse/KEYCLOAK-2798" target="_blank">https://issues.jboss.org/browse/KEYCLOAK-2798</a>.<span><font color="#888888"><div><br></div><div>Lance</div></font></span></div><div><div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Apr 11, 2016 at 2:21 PM, Bruno Oliveira <span dir="ltr"><<a href="mailto:bruno@abstractj.org" target="_blank">bruno@abstractj.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr">+1 for consistency and release dates. But I'd keep the release version independent, move from 0.0.16 to 1.9.2 for example, is a huge bump.</div><div><div><br><div class="gmail_quote"><div dir="ltr">On Mon, Apr 11, 2016 at 1:43 PM Stian Thorgersen <<a href="mailto:sthorger@redhat.com" target="_blank">sthorger@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><p dir="ltr">We discussed this at the f2f and I believe we should keep it consistent across all adapters.</p>
<p dir="ltr">The decision was to have all adapters released when the server is released and they will have the same version numbers. We will also make sure release notes mark which adapters have changed and also which are required to update (either due to compatibility changes or security related fixes).</p>
<p dir="ltr">So I'd like the ability to release nodejs adapters at the same time I do the release of the server.</p>
<p dir="ltr">We can certainly discuss changes to the above, but it should be consistent for all our adapters.</p>
<div class="gmail_quote"></div><div class="gmail_quote">On 11 Apr 2016 17:09, "Bruno Oliveira" <<a href="mailto:bruno@abstractj.org" target="_blank">bruno@abstractj.org</a>> wrote:<br type="attribution"></div><div class="gmail_quote"><blockquote style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><span style="color:rgb(34,34,34);font-family:arial,sans-serif;line-height:normal">Good morning, </span><br style="color:rgb(34,34,34);font-family:arial,sans-serif;line-height:normal"><br style="color:rgb(34,34,34);font-family:arial,sans-serif;line-height:normal"><span style="color:rgb(34,34,34);font-family:arial,sans-serif;line-height:normal">Today I was chatting with Lance about the release cadence for Node.js adapters. </span><br style="color:rgb(34,34,34);font-family:arial,sans-serif;line-height:normal"><br style="color:rgb(34,34,34);font-family:arial,sans-serif;line-height:normal"><span style="color:rgb(34,34,34);font-family:arial,sans-serif;line-height:normal">My initial idea was to release the adapters at exactly the same release dates as the official Keycloak release in order to guarantee compatibility. For critical/urgent patches, we just release those modules based on our judgment.</span><br style="color:rgb(34,34,34);font-family:arial,sans-serif;line-height:normal"><br style="color:rgb(34,34,34);font-family:arial,sans-serif;line-height:normal"><span style="color:rgb(34,34,34);font-family:arial,sans-serif;line-height:normal">Lance would like more flexibility between those releases. For example, release npm modules before the official release for situations where a user wants </span><span style="color:rgb(34,34,34);font-family:arial,sans-serif;line-height:normal">some new capability that is perhaps unrelated to changes in KC itself e.g. a move to promises.</span><div style="color:rgb(34,34,34);font-family:arial,sans-serif;line-height:normal"><br></div><div style="color:rgb(34,34,34);font-family:arial,sans-serif;line-height:normal">I don't have any problems on keeping Node.js adapters' release independent from official KC release, but would like to hear more opinions about it.<font color="#888888"><br><br>-- <br><br><br>-<br>abstractj</font></div></div>
<br></blockquote></div><div class="gmail_quote"><blockquote style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">_______________________________________________<br>
keycloak-dev mailing list<br>
<a href="mailto:keycloak-dev@lists.jboss.org" target="_blank">keycloak-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/keycloak-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailman/listinfo/keycloak-dev</a><br></blockquote></div>
</blockquote></div>
</div></div><br>_______________________________________________<br>
keycloak-dev mailing list<br>
<a href="mailto:keycloak-dev@lists.jboss.org" target="_blank">keycloak-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/keycloak-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailman/listinfo/keycloak-dev</a><br></blockquote></div><br></div>
</div></div></blockquote></div><br></div>
</div></div><br>_______________________________________________<br>
keycloak-dev mailing list<br>
<a href="mailto:keycloak-dev@lists.jboss.org" target="_blank">keycloak-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/keycloak-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailman/listinfo/keycloak-dev</a><br></blockquote></div></div></div><br></div></div>
</blockquote></div><br></div></div>