<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Has to be a merge, otherwise you break backward compatibility.<br>
<br>
<div class="moz-cite-prefix">On 4/13/2016 2:03 PM, Stian Thorgersen
wrote:<br>
</div>
<blockquote
cite="mid:CAJgngAeM1KgZMPGNF1dakS7O4ngBN7FXsAAMr0oLJA8N9PSuCg@mail.gmail.com"
type="cite">
<div dir="ltr">Rename or merge either works for me. We need it
resolved asap though. Yes, we're going to have to re-test all
adapters and examples because of this :(</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On 13 April 2016 at 18:18, Bill Burke <span
dir="ltr"><<a moz-do-not-send="true"
href="mailto:bburke@redhat.com" target="_blank">bburke@redhat.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000"> Wait! Maybe we
should just merge adapter-spi and adapter-spi-public. Its
not that big a deal to have adapter-spi be public.
<div>
<div class="h5"><br>
<br>
<div>On 4/13/2016 12:10 PM, Marek Posolda wrote:<br>
</div>
</div>
</div>
<blockquote type="cite">
<div>
<div class="h5"> Found that fuse adapter doesn't work
due to adapters packaging changes. JIRA is here: <a
moz-do-not-send="true"
href="https://issues.jboss.org/browse/KEYCLOAK-2816"
target="_blank"><a class="moz-txt-link-freetext" href="https://issues.jboss.org/browse/KEYCLOAK-2816">https://issues.jboss.org/browse/KEYCLOAK-2816</a></a><br>
<br>
Among some minor things, the biggest issue is that
osgi doesn't work properly if there are 2 modules
with classes inside same package. There is
"adapter-spi" and "adapter-spi-public" modules with
both having classes inside package
"org.keycloak.adapters.spi". So the easiest solution
was just to rename the package. <br>
<br>
There was possibility to rename either:<br>
(1) the one inside "adapter-spi" <br>
(2) or the one inside "adapter-spi-public" .<br>
<br>
I've actually chose the (1) and renamed the one
inside "adapter-spi" to "org.keycloak.adapters.<span
style="background-color:#e4e4ff">spi</span>
.internal". Only reason is that there might be some
users, who are using classes AuthenticationError or
LogoutError, so they don't need to change the code
of their applications because upgrade. On the other
hand the (2) (rename the package inside
"adapter-spi-public" to
"org.keycloak.adapters.spi.public" and keep the one
inside "adapter-spi" unrenamed) have the advantage
of better consistency among module names and package
names. So if you rather want me to go this way, let
me know and I can change it.<br>
<br>
For now, the PR against 1.9.x for path1 is here: <a
moz-do-not-send="true"
href="https://github.com/keycloak/keycloak/pull/2614"
target="_blank"><a class="moz-txt-link-freetext" href="https://github.com/keycloak/keycloak/pull/2614">https://github.com/keycloak/keycloak/pull/2614</a></a>
. There are 72 affected files because of package
renamed, but all of them are inside adapters. Will
send PR against master too if you agree with the
path1. Not sure if we rather need to retest all the
examples because of the change... <span><span> :-(
</span></span><br>
<br>
Marek<br>
<br>
<fieldset></fieldset>
<br>
</div>
</div>
<pre>_______________________________________________
keycloak-dev mailing list
<a moz-do-not-send="true" href="mailto:keycloak-dev@lists.jboss.org" target="_blank">keycloak-dev@lists.jboss.org</a>
<a moz-do-not-send="true" href="https://lists.jboss.org/mailman/listinfo/keycloak-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/keycloak-dev</a></pre>
<span class="HOEnZb"><font color="#888888"> </font></span></blockquote>
<span class="HOEnZb"><font color="#888888"> <br>
<pre cols="72">--
Bill Burke
JBoss, a division of Red Hat
<a moz-do-not-send="true" href="http://bill.burkecentral.com" target="_blank">http://bill.burkecentral.com</a></pre>
</font></span></div>
<br>
_______________________________________________<br>
keycloak-dev mailing list<br>
<a moz-do-not-send="true"
href="mailto:keycloak-dev@lists.jboss.org">keycloak-dev@lists.jboss.org</a><br>
<a moz-do-not-send="true"
href="https://lists.jboss.org/mailman/listinfo/keycloak-dev"
rel="noreferrer" target="_blank">https://lists.jboss.org/mailman/listinfo/keycloak-dev</a><br>
</blockquote>
</div>
<br>
</div>
</blockquote>
<br>
<pre class="moz-signature" cols="72">--
Bill Burke
JBoss, a division of Red Hat
<a class="moz-txt-link-freetext" href="http://bill.burkecentral.com">http://bill.burkecentral.com</a></pre>
</body>
</html>