<div dir="ltr">I'm afraid I've already merged this. I could change it back, but in the future we will start using JDK8 features on the server side, that means all modules not used by adapters will be allowed to use JDK8 features. It seems like a better way forward would be to solve the issue (my PermissionsTests will be horrible without lambdas as well).<div><br></div><div>Why are the servlets in "tests/base" at all? Seems like these are only used by "tests/other/adapters" and that's where they should be. Base should focus on only testing the server itself. If the servlets are moved there we can make only "tests/base" use JDK8. That would solve the problem right?</div></div><div class="gmail_extra"><br><div class="gmail_quote">On 5 May 2016 at 11:46, Michal Hajas <span dir="ltr"><<a href="mailto:mhajas@redhat.com" target="_blank">mhajas@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Stian,<br>
<br>
I think we may have problem with this, because our servlets are in base testsuite (<a href="https://github.com/keycloak/keycloak/tree/master/testsuite/integration-arquillian/tests/base/src/main/java/org/keycloak/testsuite/adapter/servlet" rel="noreferrer" target="_blank">https://github.com/keycloak/keycloak/tree/master/testsuite/integration-arquillian/tests/base/src/main/java/org/keycloak/testsuite/adapter/servlet</a>) and they need to be compiled with java 7. We need to be able to deploy them to containers running on java 7. Will be these files involved too?<br>
<br>
Michal.<br>
<div><div class="h5"><br>
----- Original Message -----<br>
> From: "Stian Thorgersen" <<a href="mailto:sthorger@redhat.com">sthorger@redhat.com</a>><br>
> To: "keycloak-dev" <<a href="mailto:keycloak-dev@lists.jboss.org">keycloak-dev@lists.jboss.org</a>><br>
> Sent: Tuesday, May 3, 2016 1:05:12 PM<br>
> Subject: [keycloak-dev] Enable JDK8 for testsuite<br>
><br>
> I've changed source/target to 1.8 for testsuite/integration-arquillian. This<br>
> is so I can use lambdas for testing permissions (otherwise I end up with<br>
> extremely messy tests with loads of anonymous inner classes).<br>
><br>
> Anyone have any issues with that?<br>
><br>
> In 2.x we can look at setting 1.8 as default for everything except adapters<br>
> and shared modules.<br>
><br>
</div></div>> _______________________________________________<br>
> keycloak-dev mailing list<br>
> <a href="mailto:keycloak-dev@lists.jboss.org">keycloak-dev@lists.jboss.org</a><br>
> <a href="https://lists.jboss.org/mailman/listinfo/keycloak-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailman/listinfo/keycloak-dev</a><br>
</blockquote></div><br></div>