Thanks. I created a JIRA issue.<div><a href="https://issues.jboss.org/browse/KEYCLOAK-3397">https://issues.jboss.org/browse/KEYCLOAK-3397</a></div><div><br></div><div>I'll send a pull request later!</div><div><br></div><div><br><div class="gmail_quote"><div dir="ltr">2016年8月3日(水) 17:05 Thomas Darimont <<a href="mailto:thomas.darimont@googlemail.com">thomas.darimont@googlemail.com</a>>:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>Hello Hiroyuki,</div><div><br></div><div>I'd say just go ahead and feel free to create a JIRA issue - and reference the issue number in your commit like</div><div>KEYCLOAK-XXX Add Japanese localization.</div><div><br></div><div>Try to keep your changes in a single commit in your pull request, this makes it easier to apply (e.g. via cherry-pick) - I listed my workflow for reference below.<br></div><div>Once you're done with your PR just add a link to it to the JIRA issue (in the JIRA issue, press "." then type "git" -> which brings you the to the "add git pull request" dialog.</div><div><br></div><div>If you want an example for a JIRA issue here is a similar ticket for french translation:</div><div><a href="https://issues.jboss.org/browse/KEYCLOAK-1903" target="_blank">https://issues.jboss.org/browse/KEYCLOAK-1903</a></div><div><br></div><div>Cheers,</div><div>Thomas</div><div><br></div><div>My workflow:</div><div><div>I tend to create a separate branch for every JIRA issue, so I do the following (from a checked out master branch)</div><div>0) git clone <a href="https://github.com/thomasdarimont/keycloak" target="_blank">https://github.com/thomasdarimont/keycloak</a></div><div> (origin is my keycloak fork)</div><div> git remote add upstream <a href="https://github.com/keycloak/keycloak" target="_blank">https://github.com/keycloak/keycloak</a></div><div> (upstream is original keycloak)</div><div>1) git checkout -b issue/KEYCLOAK-XXX-short-description<br></div><div>(this will create and checkout the branch)</div><div>2) code...</div><div>3) git add .</div><div>4) git commit -m (or use a graphical git client like gitg on linux, or gitx on osx)</div><div>5) git push -u origin issue/KEYCLOAK-XXX-short-description</div><div>6) on your cloned github project you should now see a link for: create pull request for the newly pushed branch - click and the PR is there</div><div>if I need to change stuff in the PR (before it is merged) I do the following</div><div>7) change...</div><div>8) git add .</div><div>9) git commit --amend (or use a graphical git client like gitg on linux, or gitx on osx)</div><div>10) git push -f origin issue/KEYCLOAK-XXX-short-description</div><div>(this will update your PR as well, but github is smart enough to retain potentially PR comments if those places didn't change)</div><div>11) goto 7) if necessary</div></div><div><br></div><div>Updating your keycloak fork from original keycloak upstream</div><div>1) git checkout master</div><div>2) git pull upstream master</div><div>3) git push origin master</div><div>(to update the master branch in your fork if necessary)</div><div><br></div><div>to update an issue branch to the latest master</div><div>1) git checkout issue/KEYCLOAK-XXX-short-description</div><div>2) git rebase master</div><div>(your issue branch is now based on the latest changes from master)</div><div>3) git push -f origin issue/KEYCLOAK-XXX-short-description</div></div><div class="gmail_extra"><br><div class="gmail_quote"></div></div><div class="gmail_extra"><div class="gmail_quote">2016-08-03 5:19 GMT+02:00 Hiroyuki Wada <span dir="ltr"><<a href="mailto:wadahiro@gmail.com" target="_blank">wadahiro@gmail.com</a>></span>:<br></div></div><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hello all,<br>
<br>
I am translating all base theme messages to Japanaese language now.<br>
(I think I can do it by the end of the week.)<br>
<br>
I'd like to contribute the message resources, How do you think?<br>
If it's ok, I'll create a JIRA issue and create a pull request.<br>
<br>
Regards,<br>
<br>
--<br>
Hiroyuki Wada<br>
<a href="mailto:wadahiro@gmail.com" target="_blank">wadahiro@gmail.com</a><br></blockquote></div></div><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
_______________________________________________<br>
keycloak-dev mailing list<br>
<a href="mailto:keycloak-dev@lists.jboss.org" target="_blank">keycloak-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/keycloak-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailman/listinfo/keycloak-dev</a><br>
</blockquote></div><br></div>
</blockquote></div></div>