<div dir="ltr">Sure</div><div class="gmail_extra"><br><div class="gmail_quote">On 16 August 2016 at 10:53, Hiroyuki Wada <span dir="ltr"><<a href="mailto:wadahiro@gmail.com" target="_blank">wadahiro@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">By the way, I found some minor issues in UI like missing message key<br>
during this translation work.<br>
Could I create a JIRA issue and send a PR?<br>
<br>
Regards,<br>
<br>
--<br>
Hiroyuki Wada<br>
<div class="HOEnZb"><div class="h5"><br>
On Fri, Aug 5, 2016 at 10:13 AM, Hiroyuki Wada <<a href="mailto:wadahiro@gmail.com">wadahiro@gmail.com</a>> wrote:<br>
>> Just a note that we can accept localization PR if you also take care of<br>
>> maintain your locale in future releases.<br>
><br>
> Yes, I will maintain it.<br>
><br>
> Regards,<br>
><br>
> --<br>
> Hiroyuki Wada<br>
><br>
><br>
> On Thu, Aug 4, 2016 at 5:02 PM, Marek Posolda <<a href="mailto:mposolda@redhat.com">mposolda@redhat.com</a>> wrote:<br>
>> Just a note that we can accept localization PR if you also take care of<br>
>> maintain your locale in future releases.<br>
>><br>
>> Thanks,<br>
>> Marek<br>
>><br>
>><br>
>> On 04/08/16 03:46, Hiroyuki Wada wrote:<br>
>><br>
>> Thanks. I created a JIRA issue.<br>
>> <a href="https://issues.jboss.org/browse/KEYCLOAK-3397" rel="noreferrer" target="_blank">https://issues.jboss.org/<wbr>browse/KEYCLOAK-3397</a><br>
>><br>
>> I'll send a pull request later!<br>
>><br>
>><br>
>> 2016年8月3日(水) 17:05 Thomas Darimont <<a href="mailto:thomas.darimont@googlemail.com">thomas.darimont@googlemail.<wbr>com</a>>:<br>
>>><br>
>>> Hello Hiroyuki,<br>
>>><br>
>>> I'd say just go ahead and feel free to create a JIRA issue - and reference<br>
>>> the issue number in your commit like<br>
>>> KEYCLOAK-XXX Add Japanese localization.<br>
>>><br>
>>> Try to keep your changes in a single commit in your pull request, this<br>
>>> makes it easier to apply (e.g. via cherry-pick) - I listed my workflow for<br>
>>> reference below.<br>
>>> Once you're done with your PR just add a link to it to the JIRA issue (in<br>
>>> the JIRA issue, press "." then type "git" -> which brings you the to the<br>
>>> "add git pull request" dialog.<br>
>>><br>
>>> If you want an example for a JIRA issue here is a similar ticket for<br>
>>> french translation:<br>
>>> <a href="https://issues.jboss.org/browse/KEYCLOAK-1903" rel="noreferrer" target="_blank">https://issues.jboss.org/<wbr>browse/KEYCLOAK-1903</a><br>
>>><br>
>>> Cheers,<br>
>>> Thomas<br>
>>><br>
>>> My workflow:<br>
>>> I tend to create a separate branch for every JIRA issue, so I do the<br>
>>> following (from a checked out master branch)<br>
>>> 0) git clone <a href="https://github.com/thomasdarimont/keycloak" rel="noreferrer" target="_blank">https://github.com/<wbr>thomasdarimont/keycloak</a><br>
>>> (origin is my keycloak fork)<br>
>>> git remote add upstream <a href="https://github.com/keycloak/keycloak" rel="noreferrer" target="_blank">https://github.com/keycloak/<wbr>keycloak</a><br>
>>> (upstream is original keycloak)<br>
>>> 1) git checkout -b issue/KEYCLOAK-XXX-short-<wbr>description<br>
>>> (this will create and checkout the branch)<br>
>>> 2) code...<br>
>>> 3) git add .<br>
>>> 4) git commit -m (or use a graphical git client like gitg on linux, or<br>
>>> gitx on osx)<br>
>>> 5) git push -u origin issue/KEYCLOAK-XXX-short-<wbr>description<br>
>>> 6) on your cloned github project you should now see a link for: create<br>
>>> pull request for the newly pushed branch - click and the PR is there<br>
>>> if I need to change stuff in the PR (before it is merged) I do the<br>
>>> following<br>
>>> 7) change...<br>
>>> 8) git add .<br>
>>> 9) git commit --amend (or use a graphical git client like gitg on linux,<br>
>>> or gitx on osx)<br>
>>> 10) git push -f origin issue/KEYCLOAK-XXX-short-<wbr>description<br>
>>> (this will update your PR as well, but github is smart enough to retain<br>
>>> potentially PR comments if those places didn't change)<br>
>>> 11) goto 7) if necessary<br>
>>><br>
>>> Updating your keycloak fork from original keycloak upstream<br>
>>> 1) git checkout master<br>
>>> 2) git pull upstream master<br>
>>> 3) git push origin master<br>
>>> (to update the master branch in your fork if necessary)<br>
>>><br>
>>> to update an issue branch to the latest master<br>
>>> 1) git checkout issue/KEYCLOAK-XXX-short-<wbr>description<br>
>>> 2) git rebase master<br>
>>> (your issue branch is now based on the latest changes from master)<br>
>>> 3) git push -f origin issue/KEYCLOAK-XXX-short-<wbr>description<br>
>>><br>
>>> 2016-08-03 5:19 GMT+02:00 Hiroyuki Wada <<a href="mailto:wadahiro@gmail.com">wadahiro@gmail.com</a>>:<br>
>>>><br>
>>>> Hello all,<br>
>>>><br>
>>>> I am translating all base theme messages to Japanaese language now.<br>
>>>> (I think I can do it by the end of the week.)<br>
>>>><br>
>>>> I'd like to contribute the message resources, How do you think?<br>
>>>> If it's ok, I'll create a JIRA issue and create a pull request.<br>
>>>><br>
>>>> Regards,<br>
>>>><br>
>>>> --<br>
>>>> Hiroyuki Wada<br>
>>>> <a href="mailto:wadahiro@gmail.com">wadahiro@gmail.com</a><br>
>>>><br>
>>>> ______________________________<wbr>_________________<br>
>>>> keycloak-dev mailing list<br>
>>>> <a href="mailto:keycloak-dev@lists.jboss.org">keycloak-dev@lists.jboss.org</a><br>
>>>> <a href="https://lists.jboss.org/mailman/listinfo/keycloak-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/<wbr>mailman/listinfo/keycloak-dev</a><br>
>>><br>
>>><br>
>><br>
>><br>
>> ______________________________<wbr>_________________<br>
>> keycloak-dev mailing list<br>
>> <a href="mailto:keycloak-dev@lists.jboss.org">keycloak-dev@lists.jboss.org</a><br>
>> <a href="https://lists.jboss.org/mailman/listinfo/keycloak-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/<wbr>mailman/listinfo/keycloak-dev</a><br>
>><br>
>><br>
<br>
______________________________<wbr>_________________<br>
keycloak-dev mailing list<br>
<a href="mailto:keycloak-dev@lists.jboss.org">keycloak-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/keycloak-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/<wbr>mailman/listinfo/keycloak-dev</a></div></div></blockquote></div><br></div>